MMM-Tado wrong units

[sdetweil]

@WouterEekhout ok, but… i don’t think that is what the USER wanted… their system is in metric, but they wanted your module display to be Fahrenheit, so I would use some other varname, and check to see if they specified that, and use IT over the system value…

or because u have it as a default, if u set it to some invalid value, then check if its what you allow,
then if invalid, use system, otherwise allow users value…

[WouterEekhout]

@sdetweil I disagree, it is unclear if the current config is not working or if he wanted a custom units setting for the app. @Stoffbeuteluwe Can you clarify if you wanted to set a different unit for the app?

[Stoffbeuteluwe]

@WouterEekhout I am from Germany and I need metric unit but Sam helped me to fix and now it’s working for me.
It would be cool to have the choice in module config. Metric or imperial
Thanks to you guys

[sdetweil]

@Stoffbeuteluwe what is your main config.js units set to? up near address:

[Stoffbeuteluwe]

@sdetweil it is metric

[sdetweil]

@Stoffbeuteluwe so, the original code should have worked…

[Stoffbeuteluwe]

@sdetweil without your fix it does not work in my case

[sdetweil]

@Stoffbeuteluwe hmm…

can u share the top of your config.js, before the modules:[ line

thanks

[Stoffbeuteluwe]

@sdetweil Hello, after module update same problem
and your fix don’t work anymore…can you help me again?

var config = {
	address: "0.0.0.0", // Address to listen on, can be:
	                      // - "0.0.0.0", "127.0.0.1", "::1" to listen on loopback interface
	                      // - another specific IPv4/6 to listen on a specific interface
	                      // - "", "0.0.0.0", "::" to listen on any interface
	                      // Default, when address config is left out, is "0.0.0.0"
	port: 8080,
	ipWhitelist: [], // Set [] to allow all IP addresses
	                                                       // or add a specific IPv4 of 192.168.1.5 :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.1.5"],
	                                                       // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format :
	                                                       // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"],

	language: "de",
	timeFormat: 24,
	units: "metric",

	modules: [

[sdetweil]

@Stoffbeuteluwe ok, need an editor for this…

line 26 of MMM-Tado.js, leave alone

change all the other this.config.units to self.config.units

change them all, then change line 26 back to this.

I have opened issue 11
https://github.com/WouterEekhout/MMM-Tado/issues/11