MMM-Tado wrong units

[sdetweil]

@Stoffbeuteluwe said in MMM-Tado wrong units:

but I am not sure with the line 26

nothing… it will copy the system units to the module units info

[WouterEekhout]

@Stoffbeuteluwe I’ve updated the code with the suggestions of @sdetweil . For now I put it into a separate branch. If this solutions works for you, I will push it to the master branch.

Execute the following:

git pull
git checkout incorrect_pointer_in_getdom

Will you let us know if this solved your problem?

[Stoffbeuteluwe]

@WouterEekhout sorry does not work

Last login: Sat Jun  6 20:48:53 on ttys000
patrickhahn@Patricks-Mini ~ % cd ~/MagicMirror/modules
patrickhahn@Patricks-Mini modules % git clone https://github.com/WouterEekhout/MMM-Tado
Cloning into 'MMM-Tado'...
remote: Enumerating objects: 47, done.
remote: Counting objects: 100% (47/47), done.
remote: Compressing objects: 100% (39/39), done.
remote: Total 152 (delta 22), reused 23 (delta 6), pack-reused 105
Receiving objects: 100% (152/152), 841.64 KiB | 973.00 KiB/s, done.
Resolving deltas: 100% (50/50), done.
patrickhahn@Patricks-Mini modules % cd MMM-Tado
patrickhahn@Patricks-Mini MMM-Tado % npm install
npm WARN deprecated simple-oauth2@2.5.2: simple-oauth2 v2 is no longer supported. Please upgrade to v3 for further support
npm WARN deprecated mkdirp@0.5.1: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated wreck@14.2.0: This module has moved and is now available at @hapi/wreck. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated boom@7.3.0: This module has moved and is now available at @hapi/boom. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated bourne@1.1.2: This module has moved and is now available at @hapi/bourne. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm WARN deprecated hoek@6.1.3: This module has moved and is now available at @hapi/hoek. Please update your dependencies as this version is no longer maintained an may contain bugs and security issues.
npm notice created a lockfile as package-lock.json. You should commit this file.
added 42 packages from 446 contributors and audited 42 packages in 5.628s

1 package is looking for funding
  run `npm fund` for details

found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
patrickhahn@Patricks-Mini MMM-Tado % git pull
git checkout incorrect_pointer_in_getdom
Already up to date.
Branch 'incorrect_pointer_in_getdom' set up to track remote branch 'incorrect_pointer_in_getdom' from 'origin'.
Switched to a new branch 'incorrect_pointer_in_getdom'
patrickhahn@Patricks-Mini MMM-Tado % 

[Stoffbeuteluwe]

@sdetweil it says undefined

[WouterEekhout]

@Stoffbeuteluwe I’m assuming self.config.units is undefined on line 26. If that is the case then MagicMirror is having trouble reading in your global units configuration. Are you experiencing the same problem with other modules?

For your information, I am from the Netherlands and I also use the metric units. I tried your configurations settings from the following and it works for me.

@Stoffbeuteluwe said in MMM-Tado wrong units:

@sdetweil Hello, after module update same problem
and your fix don’t work anymore…can you help me again?

If you just want to get the module running and forget about problem replace line 26 to the following:

this.config.units = 'metric';

Be sure you are on the master branch before replacing.

[Stoffbeuteluwe]

@WouterEekhout Hi my other modules work but this is not working and I don’t know why :thinking_face:
I will try to change the line 26…thanks for you help