MMM-Fitbit2 PythonShell is not a constructor

[sdetweil]

@tippon as I recall the node_helper.js code has to change the require statement to look like this

const {PythonShell} = require( 'python-shell');

just add the braces around the word
PythonShell

[Tippon]

@sdetweil Once again, you are a superstar. It’s working, thank you :)

I thought I’d tried that the other night, but for some reason it didn’t work. I don’t know if I typed it in wrong, or if I messed it up when I tried to do it remotely through my phone. Either way, it’s working now, and I’m a happy bunny :D

[Vizulize]

Hi - I have just committed this fix: https://github.com/m-roberts/MMM-Fitbit2/commit/e958665dcf63900d38f5405961a1a176d5ba2fcf

[Tippon]

@vizulize That’s great, thank you :)

[frosty_snow]

@Tippon
Hello - just wanted to inquire about this problem as I’m encountering the same thing but even with the mentioned change to the require statement it is continuing to occur.

Did you need to make any other changes or corrections to any of the files?
Thank you!

[sdetweil]

@frosty_snow can us do , from the module folder

grep version   node_modules/python_shell/package.json

[frosty_snow]

@sdetweil
Looks like I’m on 3.0.0

[dmolony]

@frosty_snow Not sure if helpful but I’m using python-shell 0.5.0 and removing the brackets around PythonShell fixed the same error for me.

[Stoffbeuteluwe]

var NodeHelper = require("node_helper");
const PythonShell = require("python-shell");

this is working for me

[Vizulize]

I have updated the module: https://github.com/m-roberts/MMM-Fitbit2/commit/27706ea0a9ab13b8d12a020f7234adf361d108ae

[sdetweil]

@vizulize i think it depends on what version of python-shell you are running…

https://github.com/extrabacon/python-shell/issues/154

your package.json says

"python-shell": "^0.5.0"

which means 0.5.0 OR ABOVE (technically ‘at minimum’)

if u want ONLY 0.5.0, take the ^ off the front…
else sometimes u will get 1.x

[Vizulize]

@sdetweil It is defined as 0.5.0 in the dependencies.

To be honest, the Python should be rewritten in JS anyway. Perhaps I will get around to doing that in the near future :thinking_face:

Then this issue goes away!

[sdetweil]

@vizulize yeh, i don’t know whay there is a python_shell lib… as exec and spawn are so easy…