• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-PGA

Scheduled Pinned Locked Moved Sport
48 Posts 7 Posters 38.8k Views 7 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • S Offline
    sdetweil @mumblebaj
    last edited by Aug 6, 2021, 12:28 PM

    @mumblebaj cool. but doesn’t change the work

    Sam

    How to add modules

    learning how to use browser developers window for css changes

    S 1 Reply Last reply Aug 6, 2021, 6:42 PM Reply Quote 0
    • S Offline
      swvalenti Project Sponsor @sdetweil
      last edited by Aug 6, 2021, 6:42 PM

      @sdetweil I tried pulling an issue ticket on github to no avail. @mumblebaj what is a screen scraper and can you assist in fixing?

      S 1 Reply Last reply Aug 6, 2021, 6:46 PM Reply Quote 0
      • S Offline
        sdetweil @swvalenti
        last edited by Aug 6, 2021, 6:46 PM

        @swvalenti remember this is volunteer work… we have other things in our lives…

        many developers do this in the winter when they are stuck in the house. and when they can go outside, they do…

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        S 1 Reply Last reply Aug 6, 2021, 6:55 PM Reply Quote 0
        • S Offline
          swvalenti Project Sponsor @sdetweil
          last edited by Aug 6, 2021, 6:55 PM

          @sdetweil said in MMM-PGA:

          @swvalenti remember this is volunteer work… we have other things in our lives…

          many developers do this in the winter when they are stuck in the house. and when they can go outside, they do…

          completely understand sir

          M 1 Reply Last reply Aug 6, 2021, 7:47 PM Reply Quote 0
          • M Offline
            mumblebaj Module Developer @swvalenti
            last edited by mumblebaj Aug 6, 2021, 7:57 PM Aug 6, 2021, 7:47 PM

            @swvalenti The issue is in the ESPN.js at line 49 or so. It is looking for defendingChampion.athlete but there isn’t one and it fails. I see you have created an issue on GitHub but sometimes the guys abandon their modules. Maybe the developer responds to you issue. You could change line 49 to the below and it should work.

            I would have done it this way:

            tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : ""
            

            94340480-6e5a-488b-be15-6a18dc792f4d-image.png

            Check out my modules at: https://github.com/mumblebaj?tab=repositories
            Check my blog-post: https://mumblebaj.xyz/

            S 1 Reply Last reply Aug 6, 2021, 8:07 PM Reply Quote 1
            • S Offline
              swvalenti Project Sponsor @mumblebaj
              last edited by Aug 6, 2021, 8:07 PM

              @mumblebaj said in MMM-PGA:

              tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : “”

              @mumblebaj you are the man that worked thank you! I am going to do a PR and change

              S 1 Reply Last reply Aug 10, 2021, 5:40 PM Reply Quote 0
              • S Offline
                swvalenti Project Sponsor @swvalenti
                last edited by Aug 10, 2021, 5:40 PM

                I forked and made changes so module is now working again. @mumblebaj thanks for the help.

                https://github.com/swvalenti194/MMM-PGA

                M 1 Reply Last reply Aug 10, 2021, 5:42 PM Reply Quote 0
                • M Offline
                  mumblebaj Module Developer @swvalenti
                  last edited by Aug 10, 2021, 5:42 PM

                  @swvalenti Awesome. Glad it is working.

                  Check out my modules at: https://github.com/mumblebaj?tab=repositories
                  Check my blog-post: https://mumblebaj.xyz/

                  S 1 Reply Last reply Apr 23, 2022, 7:48 PM Reply Quote 0
                  • S Offline
                    swvalenti Project Sponsor @mumblebaj
                    last edited by Apr 23, 2022, 7:48 PM

                    @mumblebaj module is stuck on loading but no errors in dev console?

                    M 1 Reply Last reply Apr 23, 2022, 9:14 PM Reply Quote 0
                    • M Offline
                      mumblebaj Module Developer @swvalenti
                      last edited by Apr 23, 2022, 9:14 PM

                      @swvalenti Are you using the original module? Is this happening after upgrade to MM2.19? Did you do the normal git pull && npm install in the module folder? Is there any errors in the pm2 logs if you are using pm2 or in the console if you are using npm start?

                      Check out my modules at: https://github.com/mumblebaj?tab=repositories
                      Check my blog-post: https://mumblebaj.xyz/

                      S 1 Reply Last reply Apr 23, 2022, 9:15 PM Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 3 / 5
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy