MMM-Spotify

luizcarlosnery

Hello, thanks for this excellent module, I’ve been using it for some time but only now I came across a problem that I don’t know how to solve …
I need to hide another module when MMM-SPOTIFY is in play mode, and hide when MMM-SPOTIFY is in PAUSE.
Has as ?

lavolp3

@luizcarlosnery i haven’t looked in the code yet but a possibility might be too look if the spotify module sends notifications. If it does you might fetch these to hide your module using the notificationReceived function

skuethe

Hi everybody. I am the new owner of this module (as of last year October). I haven’t monitored these forums / this post for problems so far. If you do have technical problems with this module please be so kind to directly open an issue in the git repo:

https://github.com/skuethe/MMM-Spotify/issues

It makes working on issues a lot easier. Thanks!

As to some of the open topics / questions here of the last weeks:

@Abstr @razserv2010 I’ve recently re-worked the multi user authentication and fixed some problems with it:
https://github.com/skuethe/MMM-Spotify/releases/tag/v2.0.1
@crisvdn I am using it with MMM-Touch (which, of course, requires a touch screen) - it is a very powerful module
@luizcarlosnery there is no direct option to do this. But you can definitely get something to work. There is a build-in config option to send custom notifications on suspend / resume:
notificationsOnSuspend and notificationsOnResume - see README for more details
You could, for example, use it in addition with MMM-pages which has some nice options to handle suspending / resuming special modules based on different pages

I hope that helps for now. I have some more fixes and improvements in the pipe that will be merged in the next comming weeks.

luizcarlosnery

@lavolp3 Thanks, but I managed to solve it by editing “Spotify.js” in play (param, cb) {
this.doRequest (“/ v1 / me / player / play”, “PUT”, null, param, cb)
}

pause (cb) {
this.doRequest (“/ v1 / me / player / pause”, “PUT”, null, null, cb)
}
I included the url commands for the remote control and solved the problem.

lavolp3

@luizcarlosnery Hi @skuethe, first of all: great module.

I have set style: "mini" in my config which works well. However I have made some adjustments to picture size and text size in custom.css.
But I’m missing the scrolling title in this mode.

Also, what happens to minibar mode.
I understand you plan to remove that?

I have also corrected one issue resulting in an error if you’re not showing the account name, will send a PR on github for that.

skuethe

@lavolp3 Hey there. Thanks for the feedback.

About the style: "mini" settings:

what adjustments did you do to the picture and text sizes? This is currently still an open topic on my side - so if it is some general improvement for the module feel free to also create a PR for that
I unfortunately don’t know what you exactly mean by “the scrolling title”. Could you elaborate?

About the minibar mode:
In my opinion this design breaks completely with the other two styles as it feels and looks completely different. In addition the implementation in the code is almost completely separated, which makes maintaining it an unnecessary effort.

To be honest - I don’t even know if it is still working or if some of the changes in the past broke usage of it.
I try to get feedback from people using it - if they want to keep it etc.

About the account name issue:
Great thanks - looking forward for your PR

lavolp3

@skuethe
Module looks like this for me know

width a width of 500.

I unfortunately don’t know what you exactly mean by “the scrolling title”. Could you elaborate?

You see it here. I’d need to see the rest of the title. It could scroll. That is already implemented in the minibar I think.

Also, Volume is always at 100% for me. Played from the android app. API issue?

lavolp3

@lavolp3 said in MMM-Spotify:

Also, Volume is always at 100% for me. Played from the android app. API issue?

Confirmed API issue. Spotify API returns volume 100%, which is not the case in the app itself. Unfortunately.
Am I the only one having this issue?

lavolp3

@skuethe said in MMM-Spotify:

what adjustments did you do to the picture and text sizes? This is currently still an open topic on my side - so if it is some general improvement for the module feel free to also create a PR for that

My suggestions , generally as well as for mini mode:

font sizes are hardcoded here, I would rather use the MM classes as reference from main.css. Meaning: giving the module and sub-elements a class “small”, “xsmall” by including the config option classes. I have done that already and works well.
adjustable cover size.
option to hide module when nothing is played
spotify label small and more dimmed (like in MMM-NowPlayingOnSpotify

All of the above is not difficult to manage I guess.

A problem with the module is in my point of view the coding. It’s difficult for me to adept to sean’s style, e.g. leaving semicola completely out, indenting only with 2 spaces. But tha can be managed of course

Let me know what you like to see as PR

skuethe

@lavolp3 said in MMM-Spotify:

@lavolp3 said in MMM-Spotify:

Also, Volume is always at 100% for me. Played from the android app. API issue?

Confirmed API issue. Spotify API returns volume 100%, which is not the case in the app itself. Unfortunately.
Am I the only one having this issue?

Interesting. I have no issues with volume display and even the volume control (via touch). Works fine on all the different devices - haven’t tried android though.

font sizes are hardcoded here, I would rather use the MM classes as reference from main.css. Meaning: giving the module and sub-elements a class “small”, “xsmall” by including the config option classes. I have done that already and works well.

adjustable cover size.

option to hide module when nothing is played

spotify label small and more dimmed (like in MMM-NowPlayingOnSpotify

Let me know what you like to see as PR

Feel free to submit a PR for all those topics if you see them as a valid improvement!