Read the statement by Michael Teeuw here.
new update/upgrade script, ready for testing
-
@sdetweil said in new update/upgrade script, ready for testing:
I changed test script to do it your way… try it out
pi@raspberrypi:~/MagicMirror $ curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash On branch master Your branch is up to date with 'origin/master'.
Sam. I think the issue is, that the command is
git status
and you aliasLC_ALL=C git
to the namegit
, not the commandgit
.
You cannot use the alias as a replacement for a part of your command, but I might be wrong.I think the only solution is to check for language en_US and then for every git command either use plain git or else by using LC_ALL=C.
Or just use LC_ALL=C for every git call.
-
name git, not the command git
i don’t understand this…
its been working fine for quite a few months, handling LC_ALL and LANGUAGE, just hs system has LANG too…
anyhow, alias is supposed to work on ‘commands’ issued, and replace the started command with the replacement string (once)
this is how the git doc suggested dealing with this issue and stackexchange posts over quite some time echoed it…
I changes to the ‘LC_ALL=C git’ approach anyhow
I don’t even check now, just do it… on english system, it doesn’t hurt
-
no, I didn’t say I was on 2.10.
i have now run the script in apply mode. The output is very long and apparently it was not updated, right?
Sorry, I’ve always done the update via git. Now I am confused …
-
@spitzlbergerj yes, please erase this file
~/MagicMirror/installers/dumpactivemodules.js
it was copied early by the official updater in error
-
It is always difficult creating something and having it run flawlessly on many different systems with their many different settings, some exotic :-)
One more thing I stumbled upon when googling:
shopt -s expand_aliases
Add this before the alias command, or just at the top of your script.
Seems to work. -
@sdetweil
OK, now I have another problem :disappointed_face: . The upgrade script ran and I think it upgraded some stuff.At some point, I must have gotten my permissions mixed up. There were a number of directories that were root:root. Here there was Permission denied.
I have now corrected the owners. But now the upgrade script doesn’t run anymore, because it assumes that I am already on 2.10.
Can I force another upgrade?
-
@spitzlbergerj yes, change ‘apply’ to ‘force’
-
@evroom I decided to forget about alias altogether…
-
@sdetweil said in new update/upgrade script, ready for testing:
I decided to forget about alias altogether…
Of course, your script, your call.
Just keep it somewhere in the back of your head, should you stumble over it again in any way or form.
As I minimum I learned something new, including using alias in a script at all.Thanks for the scripts and the help you provide to all users with fresh install and / or upgrade issues, including myself.
-
@evroom thanks for your help… I had learned about the shell options to expand aliases about 10 yrs ago, and forgot… my systems all run with it on.