MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Creating Module with API Key/Secret

    Scheduled Pinned Locked Moved Development
    15 Posts 4 Posters 5.2k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • L Offline
      lilpkstud Module Developer
      last edited by

      Having trouble displaying the information that I received from Yelp API

       getDom: function() {
              var self = this;
              var wrapper = document.createElement("div");
              //If this.dataRequest is not empty
              if(this.data && this.data.length > 0){
                  console.log("MMM-Test: This.data is set" + this.data);
              
                  //Name of Business
                  var wrapperDataRequest = document.createElement("h1");
                  wrapperDataRequest.innerHTML = this.data;
                  wrapperDataRequest.className = 'yelpBusinessName';
      
                  wrapper.appendChild(imgDataRequest);
                  wrapper.appendChild(wrapperDataRequest);
              } else {
                  console.log("MMM-Test: this.data couldn't be found");
                  wrapper.innerHTML = "This didn't work";
              }
              
              return wrapper;
      	},
      
      MMM-Test: This.data is set{"id":"E8RJkjfdcwgtyoPMjQ_Olg","alias":"four-barrel-coffee-san-francisco","name":"Four Barrel Coffee","image_url":"https://s3-media1.fl.yelpcdn.com/bphoto/-_Ks4eF8aZcm3GZgUf5Urg/o.jpg","is_closed":false,"url":"https://www.yelp.com/biz/four-barrel-coffee-san-francisco?adjust_creative=joufChkTQP-Ru-G_5cRrMA&utm_campaign=yelp_api_v3&utm_medium=api_v3_business_search&utm_source=joufChkTQP-Ru-G_5cRrMA","review_count":2069,"categories":[{"alias":"coffee","title":"Coffee & Tea"}],"rating":4,"coordinates":{"latitude":37.7670169511878,"longitude":-122.42184275},"transactions":[],"price":"$","location":{"address1":"375 Valencia St","address2":"","address3":"","city":"San Francisco","zip_code":"94103","country":"US","state":"CA","display_address":["375 Valencia St","San Francisco, CA 94103"]},"phone":"+14158964289","display_phone":"(415) 896-4289","distance":1452.8696502343696}
      

      How can I display name?

      I tried this.data[0].name or this.data.name but no luck

      lavolp3L 1 Reply Last reply Reply Quote 0
      • lavolp3L Offline
        lavolp3 Module Developer @lilpkstud
        last edited by

        @lilpkstud this.data is an object, not an array. So this.data.name should do the trick. In the code above you have only this.data!?

        How to troubleshoot modules
        MMM-soccer v2, MMM-AVStock

        L 1 Reply Last reply Reply Quote 0
        • L Offline
          lilpkstud Module Developer @lavolp3
          last edited by

          @lavolp3 I deleted this.data.name because I was getting undefined and I still am

          1 Reply Last reply Reply Quote 0
          • L Offline
            lilpkstud Module Developer
            last edited by

            @lavolp3

            This line of code will show a { on my mirror so I’m assuming everything is turned into a string?

            I used JSON.stringify() in my node_helper file

                        wrapperDataRequest.innerHTML = this.data[0];
            
            
            S 1 Reply Last reply Reply Quote 0
            • S Offline
              sdetweil @lilpkstud
              last edited by

              @lilpkstud said in Creating Module with API Key/Secret:

              JSON.stringify()

              correct… u converted the object to a string… don’t need to do that

              just pass the object from helper up to module …

              then it will use the this.data.name

              Sam

              How to add modules

              learning how to use browser developers window for css changes

              1 Reply Last reply Reply Quote 2
              • strawberry 3.141S Offline
                strawberry 3.141 Project Sponsor Module Developer
                last edited by

                @lilpkstud next to what sdetweil said you should also not save your result into this.data as it is an instance property which already contains data, see https://github.com/MichMich/MagicMirror/tree/master/modules#available-module-instance-properties for reference

                Please create a github issue if you need help, so I can keep track

                S 1 Reply Last reply Reply Quote 2
                • S Offline
                  sdetweil @strawberry 3.141
                  last edited by

                  @strawberry-3-141 should call it api_data maybe!

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  1 Reply Last reply Reply Quote 0
                  • L Offline
                    lilpkstud Module Developer
                    last edited by

                    @sdetwell @strawberry-3-141 thanks guys got it to work!

                    I used JSON.Stringify() to look at the data when I was console.loggining so that was the reason why my object were turning into strings

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @lilpkstud
                      last edited by

                      @lilpkstud cool… if need it in strings someplace, need to convert it back object=JSON.parse(string)

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 2 / 2
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy