MMM-SoccerLiveScore

np27np27

@0m4r
Actually I found another issue after the fix. The scores don’t seem to be updating during games or even at regular intervals.
I’m not sure if it’s updating at all, maybe only when magicmirror restarts or if I restart the module. @0m4r can you have a look and confirm if it works for you?

0m4r

@np27np27 I guess you are correct, something is wrong since the second last update.
I have tried to reduce the number of API calls trying to have them issued only when games are on or about to start rather than each and every 2 mins… but sometimes things do not work as I expect.

You should be able to see a message at the bottom of the standings telling you when the next API request is expected to be executed, that should help d figure if the new data are requested at a meaningful time.

np27np27

@0m4r
For me the module has an api request date of yesterday! So it’s probably not called the api?

0m4r

@np27np27 probably. I have realized I have a mistake when the event is finished and the next date should be set to be used…

If you manually refresh with F5 or restart does it get any better?

np27np27

@0m4r
Yes if you manually restart MM the the data updates.

0m4r

@np27np27 alright - I will try to fix it, but it may take some time, I usually dedicate time to my side project on the weekend

np27np27

@0m4r
No problem, thanks for trying and keeping this module going 👍🏾👍🏾

0m4r

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch

> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout feature/node-fetch 
> git pull -r
> npm ci
> [RESTART MM]

I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

np27np27

@0m4r said in MMM-SoccerLiveScore:

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch
> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout node-fetch
> git pull -r
> npm ci
> [RESTART MM]
I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

Hi @0m4r ,

Ive tried the above but got an error at the checkout node-fetch line. Can’t find the file or something similar?
Still continued on and did the rest.
The mm restart has updated the module data. I will check when a game plays tonight to see if the live data changes.

0m4r

This post is deleted!

0m4r

@np27np27 said in MMM-SoccerLiveScore:

git checkout node-fetch

should be:

git checkout feature/node-fetch

np27np27

@0m4r
OK tried again, this time I received the following after npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.
npm ERR!
npm ERR!
npm ERR! Invalid: lock file’s node-fetch@2.6.6 does not satisfy node-fetch@v2.6.1
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR! /home/pi/.npm/_logs/2021-12-06T22_20_06_917Z-debug
.log

np27np27

@np27np27 said in MMM-SoccerLiveScore:

@0m4r
OK tried again, this time I received the following after npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.
npm ERR!
npm ERR!
npm ERR! Invalid: lock file’s node-fetch@2.6.6 does not satisfy node-fetch@v2.6.1
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR! /home/pi/.npm/_logs/2021-12-06T22_20_06_917Z-debug
.log

I did npm install then npm Ci and it seems no errors this time. Let’s see if it works now. I’ll let you know 👍🏾

np27np27

@0m4r,

Looks like it’s still not working. It’s gone past the api call date that is displayed at the bottom of the module and it’s not updated. Does it work for you?

0m4r

@np27np27 can you try pulling the code once more? I did mess up the logic to re-issue the API requests, but I hopefully fixed it now!

np27np27

@0m4r
Yes will try later today. Thanks for your continued effort 👍🏾

0m4r

@np27np27 there are probably still some issue, but it seems to me it now updates correctly :)

np27np27

@0m4r
No I don’t think it’s updating for me.
Maybe I need to delete the whole module and start again. I did get a few errors during the update to your new changes.
Can I reinstall from the main branch or do I reinstall and then update again how you mentioned above?

0m4r

@np27np27 I am sorry to hear that :(
you should try again from the feature/node-fetch .

if you see any errors, would you please cut&paste them in here so I can have a look at them?

would you also mind showing me your config for the module?

np27np27

@0m4r
Ok ive reinstalled and successfully updated to the feature/fetch-node branch. I think it all installed error free this time!!

Lets see how things look later today after during the premier league games. I’ll let you know how it goes.

My config for the module:

	{
		disabled: false,
		module: 'MMM-SoccerLiveScore',
		position: 'top_right',
		header: 'Live-Scores',
		config: {
			leagues: [17],
  			showNames: true,
 			showLogos: true,
 			displayTime: 20 * 1000,
  			showStandings: true,
  			showTables: true,
  			showScorers: false,
		}
	},