After update, chrome-sandbox needs root and mode 4655?

Richard238

Noticed earlier that my MM had crashed for whatever reason - it’s not been ~~touched~~ changed in weeks.

On reboot, it wanted 44 updates.
pm2 start mm then showed nothing, with the logs giving an error:

0|mm       | [10532:0127/132321.643138:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/pi/MagicMirror/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755.

I did

sudo chown root /home/pi/MagicMirror/node_modules/electron/dist/chrome-sandbox
sudo chmod 4755 /home/pi/MagicMirror/node_modules/electron/dist/chrome-sandbox

This seems to have fixed it, with MM now starting correctly.

What’s caused this, and is the chown/chmod the correct thing todo?

sdetweil

Never seen this before

karsten13

The “newer” electron versions are using sandboxing by default. But on master-branch is still the old electron 3.x active.

So are you using the develop-branch or have you edited package.json und upgraded electron?

The method to fix this is correct, an alternative way is disable sandboxing, which is not a good idea under security aspects. You can disable sandboxing e.g. by setting the environment variable ELECTRON_DISABLE_SANDBOX=1

sdetweil

@karsten13 do you know what version this came in on? I will add the bypass into the automated install and upgrade

karsten13

tested only 3.x, 6.x, 7.x
In 3.x sandbox was disabled, in >=6.x enabled

sdetweil

@karsten13 thx. I tested 6.0.12, and didn’t have problems w sandbox…

karsten13

you tested on a raspberry pi? And with a non-root user?

sdetweil

@karsten13 correct

karsten13

node@pi4:/opt/magic_mirror$ npm install
npm WARN deprecated time-grunt@2.0.0: Deprecated because Grunt is practically unmaintained. Move on to something better. This package will continue to work with Grunt v1, but it will not receive any updates.
npm WARN deprecated @types/vfile-message@2.0.0: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.

> electron-chromedriver@6.0.0 install /opt/magic_mirror/node_modules/electron-chromedriver
> node ./download-chromedriver.js


> core-js@2.6.11 postinstall /opt/magic_mirror/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"


> console-stamp@0.2.9 postinstall /opt/magic_mirror/node_modules/console-stamp
> node ./msg.js

Attention
    Console-stamp version 3.0.0 Release Candidate is out. Install by using the tag '@next'. NB: Breaking changes.
    For more details goto: https://www.npmjs.com/package/console-stamp/v/next


> electron@6.0.12 postinstall /opt/magic_mirror/node_modules/electron
> node install.js

Downloading tmp-433-1-SHASUMS256.txt-6.0.12
[============================================>] 100.0% of 5.2 kB (5.2 kB/s)

> magicmirror@2.10.0 install /opt/magic_mirror
> cd vendor && npm install

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.4: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"arm"})

audited 220 packages in 4.267s
found 5 vulnerabilities (4 low, 1 high)
  run `npm audit fix` to fix them, or `npm audit` for details

> magicmirror@2.10.0 postinstall /opt/magic_mirror
> sh untrack-css.sh && sh installers/postinstall/postinstall.sh && npm run install-fonts

MagicMirror installation successful!

> magicmirror@2.10.0 install-fonts /opt/magic_mirror
> cd fonts && npm install

audited 1 package in 0.716s
found 0 vulnerabilities

npm WARN grunt-stylelint@0.13.0 requires a peer of stylelint@^12.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"arm"})

added 1056 packages from 1151 contributors and audited 2946 packages in 119.117s

52 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

node@pi4:/opt/magic_mirror$ npm start

> magicmirror@2.10.0 start /opt/magic_mirror
> ./run-start.sh

[516:0131/000550.394975:FATAL:setuid_sandbox_host.cc(157)] The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /opt/magic_mirror/node_modules/electron/dist/chrome-sandbox is owned by root and has mode 4755.

karsten13

node@pi4:/opt/magic_mirror$ cat package.json
{
  "name": "magicmirror",
  "version": "2.10.0",
  "description": "The open source modular smart mirror platform.",
  "main": "js/electron.js",
  "scripts": {
    "start": "./run-start.sh",
    "install": "cd vendor && npm install",
    "install-fonts": "cd fonts && npm install",
    "postinstall": "sh untrack-css.sh && sh installers/postinstall/postinstall.sh && npm run install-fonts",
    "test": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests --recursive",
    "test:unit": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests/unit --recursive",
    "test:e2e": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests/e2e --recursive",
    "config:check": "node tests/configs/check_config.js",
    "lint": "grunt"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/MichMich/MagicMirror.git"
  },
  "keywords": [
    "magic mirror",
    "smart mirror",
    "mirror UI",
    "modular"
  ],
  "author": "Michael Teeuw",
  "contributors": [
    "https://github.com/MichMich/MagicMirror/graphs/contributors"
  ],
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/MichMich/MagicMirror/issues"
  },
  "homepage": "https://magicmirror.builders",
  "devDependencies": {
    "chai": "^4.1.2",
    "chai-as-promised": "^7.1.1",
    "current-week-number": "^1.0.7",
    "danger": "^3.1.3",
    "grunt": "latest",
    "grunt-eslint": "latest",
    "grunt-jsonlint": "latest",
    "grunt-markdownlint": "latest",
    "grunt-stylelint": "latest",
    "grunt-yamllint": "latest",
    "http-auth": "^3.2.3",
    "jsdom": "^11.6.2",
    "jshint": "^2.10.2",
    "mocha": "^7.0.0",
    "mocha-each": "^1.1.0",
    "mocha-logger": "^1.0.6",
    "spectron": "^8.0.0",
    "stylelint": "latest",
    "stylelint-config-standard": "latest",
    "time-grunt": "latest"
  },
  "optionalDependencies": {
    "electron": "6.0.12"
  },
  "dependencies": {
    "colors": "^1.1.2",
    "console-stamp": "^0.2.9",
    "express": "^4.16.2",
    "express-ipfilter": "^1.0.1",
    "feedme": "latest",
    "helmet": "^3.21.2",
    "iconv-lite": "latest",
    "lodash": "^4.17.15",
    "module-alias": "^2.2.2",
    "moment": "latest",
    "request": "^2.88.0",
    "rrule": "^2.6.2",
    "rrule-alt": "^2.2.8",
    "simple-git": "^1.85.0",
    "socket.io": "^2.1.1",
    "valid-url": "latest"
  },
  "_moduleAliases": {
    "node_helper": "js/node_helper.js"
  }
}

sdetweil

@karsten13 weird. I didn’t test w 2.10, but did 2.9 and changed to electron to 6.0.12

Never had a problem. Pi 3 and 4, odroid, Jetson nano.

Richard238

@karsten13 said in After update, chrome-sandbox needs root and mode 4655?:

So are you using the develop-branch or have you edited package.json und upgraded electron?

Neither that I am aware of.
All I did was apply a batch of commits.

karsten13

may you can give us more infos about your setup.

Please navigate to your magic mirror dir (/home/pi/MagicMirror) and post the result of

cat package.json
git status
node -v
npm -v

Richard238

Cat package.json

pi@pi_mirror:~/MagicMirror $ cat package.json
{
  "name": "magicmirror",
  "version": "2.11.0-develop",
  "description": "The open source modular smart mirror platform.",
  "main": "js/electron.js",
  "scripts": {
    "start": "./run-start.sh",
    "install": "cd vendor && npm install",
    "install-fonts": "cd fonts && npm install",
    "postinstall": "sh untrack-css.sh && sh installers/postinstall/postinstall.sh && npm run install-fonts",
    "test": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests --recursive",
    "test:unit": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests/unit --recursive",
    "test:e2e": "NODE_ENV=test ./node_modules/mocha/bin/mocha tests/e2e --recursive",
    "config:check": "node tests/configs/check_config.js",
    "lint": "grunt"
  },
  "repository": {
    "type": "git",
    "url": "git+https://github.com/MichMich/MagicMirror.git"
  },
  "keywords": [
    "magic mirror",
    "smart mirror",
    "mirror UI",
    "modular"
  ],
  "author": "Michael Teeuw",
  "contributors": [
    "https://github.com/MichMich/MagicMirror/graphs/contributors"
  ],
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/MichMich/MagicMirror/issues"
  },
  "homepage": "https://magicmirror.builders",
  "devDependencies": {
    "chai": "^4.1.2",
    "chai-as-promised": "^7.1.1",
    "current-week-number": "^1.0.7",
    "danger": "^3.1.3",
    "grunt": "latest",
    "grunt-eslint": "latest",
    "grunt-jsonlint": "latest",
    "grunt-markdownlint": "latest",
    "grunt-stylelint": "latest",
    "grunt-yamllint": "latest",
    "http-auth": "^3.2.3",
    "jsdom": "^11.6.2",
    "jshint": "^2.10.2",
    "mocha": "^7.0.0",
    "mocha-each": "^1.1.0",
    "mocha-logger": "^1.0.6",
    "spectron": "^8.0.0",
    "stylelint": "latest",
    "stylelint-config-standard": "latest",
    "time-grunt": "latest"
  },
  "optionalDependencies": {
    "electron": "^6.1.7"
  },
  "dependencies": {
    "colors": "^1.1.2",
    "console-stamp": "^0.2.9",
    "express": "^4.16.2",
    "express-ipfilter": "^1.0.1",
    "feedme": "latest",
    "helmet": "^3.21.2",
    "iconv-lite": "latest",
    "lodash": "^4.17.15",
    "module-alias": "^2.2.2",
    "moment": "latest",
    "request": "^2.88.0",
    "rrule": "^2.6.2",
    "rrule-alt": "^2.2.8",
    "simple-git": "^1.85.0",
    "socket.io": "^2.1.1",
    "valid-url": "latest"
  },
  "_moduleAliases": {
    "node_helper": "js/node_helper.js"
  }
}
pi@pi_mirror:~/MagicMirror $

GIT Status:

pi@pi_mirror:~/MagicMirror $ git status
On branch develop
Your branch is behind 'origin/develop' by 17 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   css/main.css

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	InstallGuideURL.txt
	MMM-EventHorizon/
	READ_ME.txt
	core
	css/customOLD.css
	modules/default/calendar/calendar1.js
	modules/default/compliments/compliments.js.ORIG
	modules/default/compliments/compliments.json
	modules/default/compliments/compliments2.js

no changes added to commit (use "git add" and/or "git commit -a")

Node Version:

pi@pi_mirror:~/MagicMirror $ node -v
v6.9.5

NPM Version:

pi@pi_mirror:~/MagicMirror $ npm -v
3.10.10

karsten13

thx, so you are on the develop branch with electron 6.x

sdetweil

@karsten13 and old node and npm

karsten13

yes, saw that, but my tests were run with

node@pi4:/opt/magic_mirror$ node -v
v13.5.0
node@pi4:/opt/magic_mirror$ npm -v
6.13.4

sdetweil

@karsten13 u are ok, he is downlevel…

installer is still only checking node 10 minimum… should I change it?

karsten13

thats your decision, this problem seems unrelated to the node/npm version, but so old stuff can cause other problems, so may you should warn at least …

sdetweil

@karsten13 if installer is used, i upgrade to latest 10.x, and latest npm… don’t warn