MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    MMM-RottenTomatoes displays awaiting update

    Scheduled Pinned Locked Moved Unsolved Troubleshooting
    25 Posts 10 Posters 6.0k Views 10 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • E Offline
      EdO
      last edited by

      The MMM-RottenTomatoes module has been displaying "Awaiting update for a couple of days now yet when I go and do a git pull I’m told the module is up to date. Any idea what is going on.

      1 Reply Last reply Reply Quote 0
      • H Offline
        haywire
        last edited by

        Rotten tomato changed to there web format recently. Small changes are needed to the NPMJS-rt-scraper index.js file to support the changes. My changes were base @Parnic changes.
        Below is my update index.js replacing the installed package rt-scaper index.js will correct the issue.
        https://github.com/haywirecoder/NPMJS-rt-scraper/blob/master/index.js.

        D 1 Reply Last reply Reply Quote 0
        • E Offline
          EdO
          last edited by

          Thanks, I’ll try that tonight.

          1 Reply Last reply Reply Quote 0
          • D Offline
            Dizzydude @haywire
            last edited by Dizzydude

            @haywire Thanks for this. I’m a newbie, could you walk me through the steps of updating this file with the one that you provided? I tried searching my MMM-RottenTomatoes folder for any mention of index.js or rt-scraper and nothing came up.

            EDIT: Found the file, located here: /MagicMirror/modules/node_modules/rt-scraper/index.js. I’ve copied and pasted the text from the git link however it’s still Awaiting Update. Not sure if I did something wrong.

            1 Reply Last reply Reply Quote 0
            • I Offline
              ifzer0c00lsucked
              last edited by

              I also copied and pasted your code and it is still stuck in awaiting update? Any help getting this cool little module to work would be greatly appreciated.

              1 Reply Last reply Reply Quote 0
              • H Offline
                haywire
                last edited by

                Sorry to hear it didn’t work for you. I am making the assumption your using the original pull which were from https://github.com/AdamMoses-GitHub/NPMJS-rt-scraper.
                Unfortunately, I modified the original MMM-RottenTomatoes, so I don’t have a like for a like environment, but assumed correction would work for the original module.

                The root of the problem is Rotten Tomato new web format, which is part of rt-scraper (which you found).

                As indicate my fix were based on another user correction. You can attempt to pull or replace using his build.

                https://github.com/parnic/NPMJS-rt-scraper

                He has also updated his repo for RottenTomatoes module it self and updated the dependency. I haven’t tried it, but seem he best overall re-package solution.
                https://github.com/parnic/MMM-RottenTomatoes

                If that still doesn’t work and have time I can re-package my update, but it would be base on slight modified version of MMM-RottenTomatoes.

                I T 2 Replies Last reply Reply Quote 0
                • I Offline
                  ifzer0c00lsucked @haywire
                  last edited by

                  @haywire it worked. took some time for the first update but after that it has been working perfectly. THANKS!

                  1 Reply Last reply Reply Quote 0
                  • T Offline
                    tomyboy96 Project Sponsor @haywire
                    last edited by

                    Hey @haywire!

                    I tried this but it did not work for me…

                    Tried removing old MMM-RottenTomatoes and installing https://github.com/parnic/MMM-RottenTomatoes

                    It got the “Awaiting update” message fixed but the only thing showing up now is the:
                    box office, opening this week, coming soon
                    without any movies.

                    IMG_5851.jpg

                    Using the same config.js as I did for the old MMM-RottenTomatoes

                    Also tried manually removing rt-scraper and then cloning from https://github.com/parnic/NPMJS-rt-scraper but still no success…

                    Any ideas?

                    R 1 Reply Last reply Reply Quote 0
                    • A Offline
                      airs747
                      last edited by airs747

                      I found a (dirty) workaround.
                      Inspecting https://www.rottentomatoes.com/m/dream_horse, you can see the sidebar that used to be on the homepage. The structure is the same as before, except that the name of the div-element is different than assumed in the rt-scraper code.

                      So, this is what I did to get it working:

                      1. Go to the node-modules/rt-scraper directory in your MagicMirror installation dir.
                      2. Edit index.js
                      3. Replace the three instances of “homepage-top-box-office” with “movies_sidebar”
                      4. Replace the request uri rottentomatoes.com to rottentomatoes.com/m/dream_horse
                      5. Restart MagicMirror and you should now see the RT movie listing appearing again.

                      Now, this is dirty, because of the Dream Horse link. I’m think about a better way (take the first movie on the site?) and commit to github. But for now we can at least enjoy the movie listings again.

                      S R 2 Replies Last reply Reply Quote 0
                      • S Offline
                        sdetweil @airs747
                        last edited by

                        @airs747 said in MMM-RottenTomatoes displays awaiting update:

                        ’m think about a better way (take the first movie on the site?) and commit to github

                        find the github repo for the module you fixed,
                        fork it (now YOU have a linked ‘copy’)

                        make the same changes, commit to YOUR copy
                        and then offer a Pull Request (new pull request button) to the source to fix the problem for all

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        lavolp3L 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 1 / 3
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy