weatherforecast showing only two days.

[castletonroad]

This fix worked for me too, so thanks very much.

Also, showRainAmount: “false” does not work - i still see mm rain forecast against each day.

This is all a little disappointing as up until the recent upgrade, ‘weatherforecast’ was working perfectly.

And BTW, in trying to resolve the problem with ‘weatherforecast’, before coming to this thread, I also tried the ‘weather’ module, the replacement for ‘currentweather’ and ‘weatherforecast’. I couldn’t get that to work in ‘forecast’ mode, only in ‘current’ mode. The module just displays ‘Loading…’.

Ho-hum…

[sdetweil]

@castletonroad

how about no quotes

showRainAmount: false,

values that are all numbers, or true and false do not need quotes
everything else does need quotes

[castletonroad]

@sdetweil Great, that sorted things nicely!

How ever did I miss that in the config instructions… :astonished_face:

[tenyo]

@oemel09 Thanks a lot!

[dh1201]

Thanks for the ‘quick fix’ - Works perfectly.

[ArthurOff]

Will this be fixed in the next update or do we need to adjust manually?

[sdetweil]

@ArthurOff next release (3 months), OR you can use the develop branch now til then, 2.12+.

[ArthurOff]

@sdetweil haha, got it!

[DavidCarreira]

@oemel09 Thanks, your fix is working fine!

[FatTony123]

@oemel09… yep, just can confirm. This fix works like charm ;-)

[Wilfried]

@oemel09 Perfect. Thanks for the workaround.

[Hindenberg]

@oemel09 thx for your support. Different to many others, this fix doesn’t work for me. I’m running MM in a docker container and am not able to keep line 297 of weatherforecast.js edited. It always jumps back into its origin version:

params += "&cnt=" + (this.config.maxNumberOfDays < 1 || this.config.maxNumberOfDays > 17 ? 7 : this.config.maxNumberOfDays);

I tried in /mounts/modules/default/weatherforecast/ and also inside the container. I also set the container environment: MM_OVERRIDE_CSS: "false", but no way, after restarting the container, it is always showing the “old” values above
Any hints?

[amarand]

@oemel09

Patch worked for me, thank you!

[karsten13]

@Hindenberg

If you are using this setup https://gitlab.com/khassel/magicmirror#default-modules you need also set MM_OVERRIDE_DEFAULT_MODULES: "false"

[Hindenberg]

@karsten13 was pretty sure I did this. Works perfect, thanks a lot.

[kayakbabe]

@castletonroad I have had the same eperience too.

[zxjason]

@oemel09 Thanks, your fix is working fine!

[radioman]

I have the same Problem
Thanks, your fix is working very good

[MacRock]

Hey guys,

may I’m to silly for that stuff but I’m not able to fix the 2 day problem.

If I change something in the weatherforecast.js and reboot the pi, every value is default again. I have changed a file named entrypoint.sh in the build directory. I set there both MM_OVERRIDE values to “false”.

Can please anybody help me to fix that?

[karsten13]

If you are using this docker setup you have to set the MM_OVERRIDE values in the docker-compose.yml file as described in the link above (and not in entrypoint.sh).

The simple solution is to use the develop-image which contains already the changes you want to do. In this case you have to edit the docker-compose.yml file and replace the image from karsten13/magicmirror:latest to karsten13/magicmirror:develop.

In both cases after editing the docker-compose.yml file you have to restart the container. So navigate into the directory where the docker-compose.yml file is located and run docker-compose up -d.