MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Add pictures to the newsfeed module

    Scheduled Pinned Locked Moved Feature Requests
    4 Posts 3 Posters 3.0k Views 4 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • T Offline
      TheSwissGuy
      last edited by TheSwissGuy

      Hey there
      I created a recipe module to inspire myself what to cook next evening. Therefore I just copied the default newsfeed module and added some html blocks to show the image referenced by the rss entry.

      Nice try but my developer’s heart is bleeding because copying code is always a bad idea.

      What about adding this functionality to show images referenced in rss news feeds to the default newsfeed module and make it configurable to activate the images? I could add this feature and make a pull request, what do you think? So in this case everybody could use the newsfeed module to display anything and in cases of e.g. recipes to show an image as well.

      BTW: Thank you very much for starting this absolutely great open source project and everybody for participating. I love my mirror!

      Regards,
      Stephan

      cowboysdudeC 1 Reply Last reply Reply Quote 1
      • R Offline
        roramirez Core Contributors
        last edited by

        Hi @TheSwissGuy

        Sound good add an option for showing images in newsfeed. I like it.

        you can do it in the copy new module I think is not hard do it into the newsfeed. The project is always open a new contribution.

        Feel you free send a Pull Request. I really like see the feature into MagicMirror and done from your side :)

        Easy module development with MagicMirror Module Template

        1 Reply Last reply Reply Quote 0
        • T Offline
          TheSwissGuy
          last edited by

          Hi @roramirez
          I just created a pull request, my first one ever! I hope I did everything right and you like it. Looking forward for any comments and enhancement tips.

          1 Reply Last reply Reply Quote 0
          • cowboysdudeC Offline
            cowboysdude Module Developer @TheSwissGuy
            last edited by

            @TheSwissGuy Copying code is okay as long as you’re not trying to take the credit for it ;)

            Why re-invent the wheel if there’s no need? :)

            1 Reply Last reply Reply Quote 0
            • 1 / 1
            • First post
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy