How to load a <script> src = " " </script> into my mirror?

morozgrafix

It would be very difficult for me to guide you through building entire module without seeing the code and understanding what it is doing. That’s the reason why I’m only able to give you bits and pieces of information. One of the things that can help is for you to create a repo on GitHub with code that you got so far and then I can take a look and possibly offer some suggestions.

In your original post you mentioned that you wanted to display CSV data from the file in HTML table format which seems a bit different from your most recent requirement:

For some context, my .csv data table contains two columns of time-series data for which I want to sum together. And then I just want to output a sentence like, “Your sum is XXX.”

To achieve the above following very rough logic would need to be implemented:

CSV file is created/updated in /home/pi/MagicMirror/modules/datafeed/file.csv
When module is loaded JS creates a variable and reads contents of the CSV file into it (similar to what compliments module does)
CSV data in that variable is parsed, sum of the values in one of the columns calculated and assigned to another variable (sum).
DOM element is created and innerHTML of that element is updated with "Your sum is " + sum
At given config interval steps 1-4 are repeated to get fresh set of data.

Is this close to something that you are trying to do?

(Above steps aren’t accounting for any error handling etc.)
BTW I don’t think you need to convert your CSV to JSON, especially if this is a simple 2 column file. Commenting out or removing xobj.overrideMimeType("application/json"); from complimentFile example should be sufficient for CSV file reading.

Thanks.

morozgrafix

I also updated JSfiddle example with sum calculation logic: https://jsfiddle.net/morozgrafix/8oz1t9g4/2/

nbrenn

@morozgrafix Thanks for your outline. It is very, very helpful and appreciated. So I tried to take what you suggested to turn it into my code, and put it onto GitHub.

I created a GitHub repository that contains my .css, .csv, and datafeed.js. My areas of confusion (which you’ll probably see in the code) are around how I called in the remoteFile in my getDom. I am not sure if I did that correctly. https://github.com/brennn1/Magic-Mirror-Datafeed-Module

My .csv is coming in the format which you’ll see on the Github - so each data point is separated by a new line. So I changed where you had the line.split(",") to line.split("\n").

Do you see anything obvious that will cause me problems? I will go ahead and see what errors I get when I load it onto my mirror.

morozgrafix

@nbrenn perfect!!! i can now see your full code and have better idea what you are trying to achieve.

Your data file is not really a CSV (Comma Separated Values) file, just a text file with values on each line, so you were correct to remove that line.split(",") part. I already spotted a few things where your code will not work correctly. I will take a closer look at it later tonight and hopefully together we can get this resolved.

morozgrafix

@nbrenn I’ve reworked the code to follow that logic outline to get Your sum is 37 to show up in the middle of the MM. You can find a PR on GitHub or just look at my fork of your repo. Most of the code is commented and hopefully easy to follow. I also added some configuration options for better flexibility.

0_1485341408447_upload-7b56fda4-6a24-42d5-8a75-8fc10ccd0dc4

Since you didn’t need a table any longer, I took some shortcuts with processing the data and just calculating the sum of all numeric values from the file. You can add the module to the MM and then as it runs update the datafile with new values, MM should update in about a minute or whatever your updateInterval is set to.

Let me know if you have any questions.

P.S. I didn’t run it on RasPi, but it should work without a problem. :fingers_crossed: Also if you are planning to make this module available for others it may be worth renaming it to MMM-datafeed to follow the standard naming conventions.

nbrenn

@morozgrafix This looks awesome! I will try to work with this over the next couple days and will let you know if I have any other questions! Thanks!

morozgrafix

@nbrenn sounds good. Good luck!

nbrenn

@morozgrafix Everything is working very well so far!

I am updating my “Sum” daily, but I would like to be able to show the previous day’s sum. Could I store the value of the sum at 11:59pm, each evening, and then display that value in addition to the current day’s sum?

Additionally, how could I modify the line of code:

this.sum = lines.reduce((a, b) => a + b, 0);

to allow for me to sum across multiple columns? So, if my .csv has 3 columns, I’d like the sum total of them.

cowboysdude

This post is deleted!

morozgrafix

@nbrenn sorry swamped at work today. That line just takes all of the values from each line and adds them up. It will not work for multiple columns and true csv files. You would need to resort to logic that we had initially in JSfiddle. If I have time I will look into this later today.