MMM-Flights

sdetweil

@lif please NEVER edit the source file. unless you KNOW what you are getting yourself into.

all config should go in config.js
everything in the defaults section can be overridden in config.js

also on forum posts use the code block wrapper for all code and config.

paste text into message editor
select pasted text
hit button </>

karsten13

@lif said in MMM-Flights:

Yes, it did work before I applied an update this morning

should be fixed now with latest version …

lif

@sdetweil said in MMM-Flights:

@lif please NEVER edit the source file. unless you KNOW what you are getting yourself into.

When the {module}.js file has lines which state something like
'units: “imperial”, // metric uses m and km/h, imperial uses ft and mph,
I assume that it can be changed in the {module}.js file.

all config should go in config.js
everything in the defaults section can be overridden in config.js

Some modules list all the options in the example that goes into the config.js file, MMM-Flights (and many others) don’t.

also on forum posts use the code block wrapper for all code and config.

paste text into message editor
select pasted text
hit button </>

OK, sorry.

lif

@karsten13 said in MMM-Flights:

@lif said in MMM-Flights:

Yes, it did work before I applied an update this morning

should be fixed now with latest version …

Sorry, still the same after (I think) installing the latest version

karsten13

@lif

was talking about showMap: "ifTraffic", and this works on my side, tested it again

lif

@karsten13 said in MMM-Flights:

@lif

was talking about showMap: "ifTraffic", and this works on my side, tested it again

Yes

 showMap: "ifTraffic", // "always", "never", "ifTraffic"

sdetweil

@lif said in MMM-Flights:

I assume that it can be changed in the {module}.js file.

no.

in config.js

the design is config js is used to override the values set in the modulename.js defaults section

lacking documentation is a different probem.

if you find properties in the defaults section you can override them in config.js

sdetweil

@lif I have a module that presents a form for config customization, built on the fly based on the modules you have installed now

it uses the values from defaults

https://github.com/sdetweil/MMM-Config

in places where there could be choices, the author can augment the definition to make it more usable and understandable.

not every module works some need help.
if the module is old or the author chooses not to provide an improved definition, I can ship one created by a user, with my module to make the user experience better.

lif

@sdetweil said in MMM-Flights:

@lif I have a module that presents a form for config customization, built on the fly based on the modules you have installed now

it uses the values from defaults

https://github.com/sdetweil/MMM-Config

in places where there could be choices, the author can augment the definition to make it more usable and understandable.

not every module works some need help.
if the module is old or the author chooses not to provide an improved definition, I can ship one created by a user, with my module to make the user experience better.

Nice advert :-) but I’ve never been able to cut and paste, in some cases , 20 - 30 lines of options from the module config file to config.js using a command line editor if the author doesn’t give all the options in the default config.js example on Git Hub.

sdetweil

@lif it’s a fun challenge.

the downside of changing the modulename.js file is, when an update comes, git pull will fail. and YOU have to figure it out.

everything takes work. I’m just trying to help you learn the best practice so you don’t get smashed later on.