MMM-Flights

[sdetweil]

@lif please NEVER edit the source file. unless you KNOW what you are getting yourself into.

all config should go in config.js
everything in the defaults section can be overridden in config.js

also on forum posts use the code block wrapper for all code and config.

paste text into message editor
select pasted text
hit button </>

[karsten13]

@lif said in MMM-Flights:

Yes, it did work before I applied an update this morning

should be fixed now with latest version …

[lif]

@sdetweil said in MMM-Flights:

@lif please NEVER edit the source file. unless you KNOW what you are getting yourself into.

When the {module}.js file has lines which state something like
'units: “imperial”, // metric uses m and km/h, imperial uses ft and mph,
I assume that it can be changed in the {module}.js file.

all config should go in config.js
everything in the defaults section can be overridden in config.js

Some modules list all the options in the example that goes into the config.js file, MMM-Flights (and many others) don’t.

also on forum posts use the code block wrapper for all code and config.

paste text into message editor
select pasted text
hit button </>

OK, sorry.

[lif]

@karsten13 said in MMM-Flights:

@lif said in MMM-Flights:

Yes, it did work before I applied an update this morning

should be fixed now with latest version …

Sorry, still the same after (I think) installing the latest version

[karsten13]

@lif

was talking about showMap: "ifTraffic", and this works on my side, tested it again

[lif]

@karsten13 said in MMM-Flights:

@lif

was talking about showMap: "ifTraffic", and this works on my side, tested it again

Yes

 showMap: "ifTraffic", // "always", "never", "ifTraffic"

[sdetweil]

@lif said in MMM-Flights:

I assume that it can be changed in the {module}.js file.

no.

in config.js

the design is config js is used to override the values set in the modulename.js defaults section

lacking documentation is a different probem.

if you find properties in the defaults section you can override them in config.js

[sdetweil]

@lif I have a module that presents a form for config customization, built on the fly based on the modules you have installed now

it uses the values from defaults

https://github.com/sdetweil/MMM-Config

in places where there could be choices, the author can augment the definition to make it more usable and understandable.

not every module works some need help.
if the module is old or the author chooses not to provide an improved definition, I can ship one created by a user, with my module to make the user experience better.

[lif]

@sdetweil said in MMM-Flights:

@lif I have a module that presents a form for config customization, built on the fly based on the modules you have installed now

it uses the values from defaults

https://github.com/sdetweil/MMM-Config

in places where there could be choices, the author can augment the definition to make it more usable and understandable.

not every module works some need help.
if the module is old or the author chooses not to provide an improved definition, I can ship one created by a user, with my module to make the user experience better.

Nice advert :-) but I’ve never been able to cut and paste, in some cases , 20 - 30 lines of options from the module config file to config.js using a command line editor if the author doesn’t give all the options in the default config.js example on Git Hub.

[sdetweil]

@lif it’s a fun challenge.

the downside of changing the modulename.js file is, when an update comes, git pull will fail. and YOU have to figure it out.

everything takes work. I’m just trying to help you learn the best practice so you don’t get smashed later on.

[stashu]

Hi! Thank you for the module, it is my favorite on my MM, as I live on the flight path to KIAD, so lots of activity.

I am wondering if there is a way I can hide the horizontal line which is under the ‘Flights’ label. When there are no flights, the line is still visible, and I would love if I were able to hide it somehow. I’m happy to add something to custom.css, but I am unsure how to do so. Thanks!

[sdetweil]

@stashu So, there is indeed custom.css entry you can use the hide the separator on the header…

BUT I want to teach you how to find these things yourself… so you won’t be dependant on waiting for someone

see the second link in my signature below, it will show you how to use the developers window elements tab and locate the element that is displaying the thing you want to modify/hide…

in the upper right window you can try different styles on the selected element to see its behavior and once you’ve found it, you can copy paste those styles into custom.css
and put the selector wrapper around it.

the selector chain is shown on the bottom of the elements window , for example here on another element

[stashu]

@sdetweil thanks for the quick reply and the pointer to finding the element. I’m not in web stuff, so it’s a bit more of a mystery to me than I wish it were. Anyway, I found it, and the following custom.css entry works to remove the header:

.MMM-Flights .module-header {
	border-bottom: 0px; /* removes line */
	font-size: 0px; /* removes 'Flights' and logo (?) */
}

Not sure if that’s an elegant way, but it works :) . I’m not clear on why the 0 font size removes the logo, but it does.

Thanks again!

[sdetweil]

@stashu all good… sorry for the firehose treatment… lol

anyhow to hide an element is actually easier

selector {
   display:none;
}

[karsten13]

@stashu said in MMM-Flights:

if there is a way I can hide the horizontal line which is under the ‘Flights’ label.

I updated the module, if you now set title and logoTitle to empty strings no header and no line is diplayed anymore.

[wswenson]

I would like to see a configuration option to filter out non-commercial flights. I played around with this code segment and think it could be done with some minor logic added for a configuration option of onlyCommercial (or something like that). I live in an area where there is a high concentration of private planes as well, and generally I am mostly interested in the commercial flights.

I tried to open an issue in Gitlabs, but wants me to create an account and pay for membership and such.

Thanks for the module!

 async makeFlightArray(configPayload) {
      let flights = [];

      const prov = configPayload.provider.toLowerCase();
      if (this.providers.includes(prov)) {
        await require(`./provider/${prov}`).getData(
          configPayload,
          flights,
          this.airports,
          this.airlines,
          this.planes,
          this.setFlightData,
          this.fetchUrl
        );
      } else {
        Log.error(
          `${this.name}: Unknown provider  + ${configPayload.provider}`
        );
      }
	  
	  // Filter out flights with empty airline
      flights = flights.filter((flight) => flight.airline && flight.airline.trim() !== "");
	  
	  console.log(flights);
      return flights;
    },

[karsten13]

@wswenson said in MMM-Flights:

I tried to open an issue in Gitlabs, but wants me to create an account and pay for membership and such.

they are free see https://about.gitlab.com/pricing/

will look into the filter stuff …

[karsten13]

@wswenson said in MMM-Flights:

I would like to see a configuration option to filter

now implemented with this commit

Thanks for the suggestion!

[wswenson]

@karsten13 Very nice and thank you!