Struggling with Weather... module

D3dl3g

in addition… looking at “ukmetofficedatahub.js”
API Base URL looks like this…
apiBase: “https://api-metoffice.apiconnect.ibmcloud.com/v0/forecasts/point/<hourly/3hourly/daily>”,

where as the next section down API URL is stated to be
“https://metoffice.apiconnect.ibmcloud.com/metoffice/production/api”

seems to be a mismatch although im still looking at where to test that theory…
i would have hoped which ever way the URL is structured its the JS info thats the important bit, not the structure of the URL

D3dl3g

I’m stumped!

As outlined here

ukmetofficedatahub.js is set to

        // Set the default config properties that is specific to this provider
        defaults: {
                apiBase: "https://api-metoffice.apiconnect.ibmcloud.com/v0/forecasts/point/daily/",
                apiKey: "<myID>",
                apiSecret: " <my secret>",
                lat: <my lat>,
                lon: <mylong>,
                windUnits: "mph"

(lines 50-55)

////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

config.js set to

  		weatherProvider: "ukmetofficedatahub",
  		apiBase: "https://api-metoffice.apiconnect.ibmcloud.com/v0/forecasts/point/daily/",
  		apiKey: "<myID>",
  		apiSecret: " <my secret>",
  		lat: <my lat>,
  		lon: <my long>,
 		windUnits: "mph",
 		tempUnits: "metric",

(lines 20-27)

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

logs are clear… many server restarts…

i can curl required info and get something vaguely intelligent from the Met office Servers

curl --request GET \
  --url 'https://api-metoffice.apiconnect.ibmcloud.com/v0/forecasts/point/hourly?excludeParameterMetadata=false&includeLocationName=true&latitude=<my lat>&longitude=<my long>' \
  --header 'X-IBM-Client-Id:  <myID>' \
  --header 'X-IBM-Client-Secret: <my secret>' \
  --header 'accept: application/json'

D3dl3g

any ideas?? @sdetweil

Is this portion of the module broke for me, do i need to use a different service?

sdetweil

@D3dl3g I don’t KNOW for sure… the provider has its own apiBase set…

* 		apiBase: "https://api-metoffice.apiconnect.ibmcloud.com/metoffice/production/v0/forecasts/point/",

so comment that out in your config
add // to the start of the line with apiBase:

also, as this doesn’t have a node helper, we should be looking in the browser logs

ctrl-shift-i, select the console tab and put

weath

in the filter field

D3dl3g

@kayakbabe
For some reason i glossed over your reply, apologies.

Trying with a different provider will be my plan of attack today. After running some diag, as sam has suggested.

I find the met office to be insanely accurate for my area when compared to other online weather services. Hence my desire to use it.

One of the reasons my posts are peppered with pictures and code is to help ensure i am setting it up correctly. I didnt realise about the .js in the weather folder for 2 days i thought it was all set up from config.js…

As it stands im convinced i have it set right, now, but its totally possible i have a comma in the wrong place. As im a total n00b with JS. i know sometimes it is difficult to see the forest through the trees and a fresh set of eyes can help.

Thank-you for your reply, looks like im experiencing option 4 😄

D3dl3g

@sdetweil,

apiBase commented out in config.

server restart, and browser log request, showing loaded weather modules

i still have “loading” in module location

looking at source gives me the impression that i need to go and look at 2 more .js files. Previously i have been working with /default/weather/ukmetofficedatahub.js and /MagicMirror/config/config.js

ill see if thes hold any info:
/root/MagicMirror/modules/default/weather/weatherproviders.js
(Edit: //weather provider properties: null, modified to:
)

/root/MagicMirror/modules/default/weather/weather.js
(Edit: this file is set to “openweathermap”, changing to “ukmetofficedatahub”

)

server restart, no effect noted :(

D3dl3g

@Kayababe @sdetweil

openweathermap works… albiet the location its suggested is 3 miles down the road. (ukmetoffice has data for 2 streets away)

sdetweil

@D3dl3g you ONLY setup from config.js

please try with NO apibase set

D3dl3g

@sdetweil

weather.js and weatherprovider.js i have set back to defaults.

i have set config.js as requested

  weatherProvider: 'ukmetofficedatahub',
  lat: "52.###############",
  long: "-1.###############",
//apiBase: 'https://api-metoffice.apiconnect.ibmcloud.com/v0/forecasts/point/daily/',
  apiKey: 'e52#############################',
  apiSecret: 'd3a#############################',

the result:-

sdetweil

@D3dl3g send me your API key… config from config.js via email or direct message so I can debug

did u look in the browser messages?

my email is my same userid at gmail

D3dl3g

Just to update the forum, as to what happened behind closed doors

Sam kindly tested my code, and it worked for him.

I am recieving browser errors (previously requested but i wasnt looking in the right bit of the browser window)… he is not

Issues Tab

Console Tab

the last 5 entries here will reoccur, im guessing at every “retry” for weather info

attempted to use useCorsProxy: true to no avail

Sam kindly posted into git hub issues.
https://github.com/MichMich/MagicMirror/issues/271

karsten13

tested ukmetofficehub and it works out of the box (without setting the useCorsProxy flag).

Looking into the provided config

  weatherProvider: 'ukmetofficedatahub',
  lat: "52.###############",
  long: "-1.###############",

which is messed up. It has to be:

  weatherProvider: 'ukmetofficedatahub',
  lat: 52.###############,
  lon: -1.###############,

sdetweil

@karsten13 I tested w those in quotes, and it worked ok

karsten13

@sdetweil

did only test without, but there is another error lon vs. long …

sdetweil

@karsten13 I just copy pasted and it worked.

weird

D3dl3g

@karsten13

i too am getting this… showing me some 80+miles SEE of my actual location

D3dl3g

@karsten13
also… replace the hash symbols with various numbers… im not posting my exact Lat/Long for obvious reasons…

make sure ur doing

lat:

and

lon:

i had it set to lat & lon(G) which is incorrect. hence why it was 80+miles, way tf over there!

quote marks or none surronding the numbers doesnt appear to matter, for me at least

D3dl3g

This “issue” is fixed.

Advised by Sam, I ran these 2 commands to find modified files that differ from a “clean install/default” of MM.

git status
git diff

Any that varied… I ran:

git checkout <dir-tree>/file.extension

Rebuilt my config.js and found that apiBase HAS to be commented out.

On reflection DO NOT CHANGE ANY FILE aside from “config.js”
I had 3 causes for this issue.

(edit) i had longitude set in config.js to “long:”… it should be “lon:” and the lat/lon do not have to be surrounded by any quote marks.
I’d modified other *.js files, that didn’t need to be modified.
the “apiBase” argument listed in (MagicMirror Documentation > Modules > Weather Module > Configuration Options) was, in my case, not “REQUIRED”.

@sdetweil … Sam, publically, I cant thank you enough for your help with this. Sorry for being a n00b, your insight and help was invaluable, and you taught me some stuff, which is great!!

sdetweil

@D3dl3g glad u got it working. we are all noobs at some of this stuff…