Default Weather module still not displaying

[Jarhead96097]

After upgrading to 2.20.0, the default Weather module has stopped displaying. I finally had some time and rebuilt my MM, reusing the same config.js. Unfortunately, I’m still receiving the “Uncaught SyntaxError: Unexpected token” error on line 159 of weather.js. Here’s my config.js with personal data xxxx’d out:

			module: "weather",
			disabled: false,
			position: "top_left",
			classes: "daytime_scheduler",
			config: {
				initialLoadDelay: 3000,
				weatherProvider: "openweathermap",
				type: "current",
				apiKey: "XXXX6abf89276a4b3cc00cfbcca7XXXX",
				location: "XXXXXX, XX",
				apiBase: "http://api.openweathermap.org/data/",
				weatherEndpoint: "/weather",
				locationID: 5574093,
				degreeLabel: true,
				updateInterval: 1800000,
				//lat: "XX.XXXX70",    //used for troubleshooting with other providers
				//lon: "-1XX.XXXX10",
				appendLocationNameToHeader: true,
				showLocationAsHeader: true,
				showWindDirection: true,
				showHumidity: true,
			}
		},

Any ideas on what to do are appreciated in advance!

[sdetweil]

@Jarhead96097 please never do audit… causes more problems than it fixes

[OldSunGuy]

The only thing I noticed was you’re trying to use http and the default is https for the apiBase.

Weather Options

[Jarhead96097]

@OldSunGuy thanks… I didn’t make any changes to the script before updating to 2.20.0 , but I changed to https. Unfortunately, it didn’t make a difference. Neither the current nor the forecast weather module instances are showing, and I’m still receiving the “Uncaught SyntaxError: Unexpected token.” error on line 159 of weather.js. And of course, I haven’t changed anything in weather.js.

Any other ideas? I appreciate your time!

[sdetweil]

@Jarhead96097 remove all the options except

apiKey
and
locationID

default type is current
default provider is openweathermap

[Jarhead96097]

@sdetweil thanks… Well, no change. I’ve tried that and also copied the portion of the weather module from the original config.js, which was renamed as config.js.sample during setup. Both attempts still result in the Unexpected Syntax Error: Unexpected token message coming from line 159 of weather.js.

You’re always very helpful, thanks for your time. Any other ideas?

[sdetweil]

@Jarhead96097

ok, I just did this

		{
			module: "weather",
			position: "top_right",
			config: {
				locationID: "361058",
				apiKey: "xxxxx"
				}
		},

try that with your openweathermap apiKey

[Jarhead96097]

@sdetweil no luck. Still receiving the same error on line 159, and no display on the MM.

[sdetweil]

@Jarhead96097

this is on pi, or windows, or ??

ok, do this

cd ~/MagicMirror
rm -rf node_modules
npm install 
#added
git checkout modules/default/weather/weather.js
git status

then try again

[Blackeye]

@Jarhead96097 Could be the comma after “true” on the last line of config … not necessary, and causes an error when I run a :check

[sdetweil]

@Jarhead96097

I added a command above to restore the original weather.js from the git repo

[Jarhead96097]

@sdetweil I added “npm audit fix” as there was 1 high severity vulnerability found. It didn’t solve the vulnerability (didn’t try “npm audit fix --force”), and I’m getting the same error.

[Jarhead96097]

@sdetweil Oh, okay. Let me try that updated string of commands…

[sdetweil]

@Jarhead96097 please never do audit… causes more problems than it fixes

[mumblebaj]

@Jarhead96097 Rule of thumb is to never run npm audit fix.

[sdetweil]

@mumblebaj and we have found npm install parms to turn off the warning coming in next release, and already in my scripts.

[mumblebaj]

@sdetweil That’s great

[Jarhead96097]

@sdetweil Good to know…that may be the root cause of all of this. After rebuilding my MM on 2.20.0, I did the npm audit fix. If we can’t get to a resolution in the next few minutes, I’ll chalk this up to a learning experience and do another rebuild.

[OldSunGuy]

May I ask how you are using

classes: "daytime_scheduler"

Are there two instances of

daytime_scheduler

I use

classes: “currentweather”

type: “current”

and

classes: “weatherforcast”

type: “forecast”

to replace the deprecated modules.

[sdetweil]

@Jarhead96097 use my install script

see
https://github.com/sdetweil/MagicMirror_scripts

[Jarhead96097]

@sdetweil “On branch master,” and up to date with origin/master. I also meant to reply earlier that this is on a RPI 4B. Unfortunately, still getting the same error and the weather module is not displaying information.

I appreciate everyone’s time…but I’m going to cut to the chase and rebuild using your install script.

Thanks again for the time, you’re always very helpful, and I appreciate it.