Default Clock wrong after update

[sdetweil]

@drstang I don’t understand this, the code does

		if (this.config.timezone) {
			now.tz(this.config.timezone);		

which means it only uses its own config values, not the global config.

when I set it like this

		{
			module: "clock",
			position: "top_left",
			config:{
				displaySeconds:false,
				timezone:"UTC"
			}
		},

it correctly changed the displayed time from 08 (us central time) to 13

if I set it like this

	timeFormat: 24,
	units: "metric",
	timezone:"UTC",
	modules: [

it did not change the displayed time (as expected)

[BKeyport]

@sdetweil Correction to your statement. timezone is set to null by default. timezone: null, - therefore, that if line would evaluate to false unless you override with timezone config item.

[sdetweil]

@BKeyport correct,

so a ‘forced’ timezone would not be set

this is the same code as before.

[BKeyport]

@sdetweil

@sdetweil said in Default Clock wrong after update:

which means it only uses its own config values, not the global config.

This is what I was correcting. ;)

[sdetweil]

@BKeyport but he said,

changing it in the module config did NOT work
but
changing it in the GENERAL config DID work…

and it was NOT set in the original config he was using prior to the upgrade

[sdetweil]

@BKeyport said in Default Clock wrong after update:

This is what I was correcting.

I don’t understand…

what I said was

this module only adjusts the timezone when

    config :{ 
        timezone: '??????',
    }

in its module definition

NOT when its set in the global configuration, (before modules defined)

timeFormat: 24,
	units: "metric",
	timezone:"UTC",  <---  added this for testing, value NOT set in module config 
	modules: [

so I don’t see what you are ‘correcting’

[drstang]

@sdetweil thats correct - when I changed timezone from ‘null’ to ‘America/New_York,’ the module did not work at all. When I went into the MM config.js and added the timezone line, it worked.

Which now I realize is also a bit frustrating because one of my modules also shows sunrise/sunset times, and thats still off (EST + 4 hrs).

[drstang]

@sdetweil and also, yes. prior to the upgrade, my general config was NOT set to a TZ prior to the upgrade. I

[sdetweil]

@drstang said in Default Clock wrong after update:

my general config was NOT set to a TZ prior to the upgrade.

correct… as there is no general timezone property

[drstang]

@sdetweil and what also confuses me is if I access the mirror via a web browser, the times are right!

[sdetweil]

@drstang I understand and agree with that…

the clock code runs in the browser… so one can only assume that the
moment code running in the browser is different between instances…

[BKeyport]

@sdetweil Curious - are we still using Moment.js in default clock? I’ve heard issues relating with Moment and newer code - I think it might be failing to the point of no return.

[sdetweil]

@BKeyport AND it looks like we SHIP a copy… that is PROBABLY the problem

[drstang]

@sdetweil Makes sense - and certainly frustrating, as I realize I’m having issues with other modules that show times as well (showing sunrise/sunset, tide charts).

Any suggestions on a fix - as it is essentially making my MM unusable since my ‘main’ modules rely on time…

[sdetweil]

@drstang I am away til Tuesday.

not sure what a fix would be

[drstang]

@sdetweil I am a total novice at JS - but I fixed my modules by adjusting the configs - I incorporated moment-timezone.js and changed my code from ‘.local()’ to ‘.tz(America/New_York)’ Seems moment was having issues with the ‘local’ part of the code.

A bit annoying, and I’m sure another way could have been used, but the modules are at least showing correct time now!

[BKeyport]

@drstang Ahh, perhaps a forgotten requirement. It seems clear we need to get rid of Moment.js