MMM-euro2024

sdetweil

@0m4r the sample is missing the config:{} section

{
  disabled: false,
  module: "MMM-euro2024",
  position: "bottom_center",
  defaults: {
    updateInterval: 60 * 1000, // one minute
  },
  token: [YOUR_TOKEN]
}

should be


{
  disabled: false,
  module: "MMM-euro2024",
  position: "bottom_center",
  config:{
       updateInterval: 60 * 1000, // one minute
       token: [YOUR_TOKEN]
   }
}

your module passes this.config to the node_helper, but there is no config block, so only {} gets passed

this.sendSocketNotification(this.name + 'CONFIG', this.config);

sdetweil

@0m4r
also, the defaults go in the modulename.js not in the node_helper.js

defaults: {
    competitionId: 2018, // Euro 2024
    updateInterval: 60 * 1000, // 1 minute
  },

this provides overridable properties via config.js

from the doc
https://docs.magicmirror.builders/development/core-module-file.html#available-module-instance-properties

0m4r

@sdetweil thanks for the detailed feedback.
I will update it as soon as I get a moment :)

0m4r

The README.md is updated.
The configuration instructions should be now correct: https://github.com/0m4r/MMM-euro2024?tab=readme-ov-file#configuration

sdetweil

@0m4r i want to nudge you a little more, on the defaults.

my MMM-Config module presents a form for config customization, and it does this by discovering the parameters in the defaults section of the modulename.js. as it sits, your module would have no parameters for the user to configure

just move that one section to the modulename.js from the node helper and all will be good. no other change to your module is required because you did that change.

robiv8

I get a black screen when I activate the module?
Original Config as in description and token available.
Does anyone know what this could be?

Ich bekomme einen Schwarzen Schirm wenn ich das Modul Aktiviere?
Original Config wie in Beschreibung und Token vorhanden.
Weiß jemand was das sein könnte?

Danke
Robert

0m4r

@robiv8 hey, I am sorry to hear that.
Are you able to provide some logs?

0m4r

@sdetweil this is done in version 1.0.4

robiv8

@0m4r
das log sagt: Please correct syntax errors at or above this line: ReferenceError: b1e6…meinToken…67c8c5 is not defined

0m4r

@robiv8 I think your configuration is wrong.
Is the token wrapped into quotes?

{
  disabled: false,
  module: 'MMM-euro2024',
  position: 'center',
  header: 'Euro 2024',
  config: {
    updateInterval: 60 * 1000,
    token: "M4g1cM1rr0r"
  }
},