Show calendar based on IP Address accessed

Spinster

@sdetweil I understand about the log. Thank you.

Regarding the IP address, I am very new to javascript hence trying to get my head around it. Being a C programmer, certain things in JavaScript is still a distant for me. Hope to understand soon.

Just in case if you have some time, a simple code from you would help me. Please.

Spinster

@MMRIZE I understand, Ideally I would like to avoid opening multiple ports and use a common config to serve clients based on their IP. In fact, though DHCP is used by my home server, I have only assigned the IP address to reservations, hence static IP within my home network is not a problem.

Please suggest a simple code to use a specific calendar based on IP address of the client.

MMRIZE

@Spinster
I’m out of my test PC, so I can’t show atm. (Maybe tomorrow possible, if you couldn’t success until that time)
You can add custom config attribute map-like object calendarMap in your config.js

module: "calendar",
position: "top_left",
config: {
  calendarMap: {
    "192.168.178.100": ["calendar1", "calendar2"],
    "192.168.178.101": ["calebdar1", "calendar3"],
  },
  calendars: [
    {
      url: " … ",
      name: "calendar1",
    },
…

In calendar.js around line 176, when CALENDAR_EVENTS notification coming, you can filter the payload(array of events) of that notification by checking calendarName of each event is matched to this.config.calendarMap.

Sorry I can’t show the real code now. Maybe some hours later I may be able to. Anyway concept would be like this.

Spinster

@MMRIZE Great, You have given me an idea, will wait for your code. Please share when possible.

MMRIZE

@Spinster
Ah I suddenly remember that getting Internal IP with only JavaScript on client browseris hard.
Hmmm another approach might be needed.

sdetweil

@MMRIZE that is why you need the express api call…

I would make a separate module that has ip in div, not shown, but w id

then call in calendar is document.get…
compare, your way or on cal entries
more synchronous…

MMRIZE

@sdetweil
Yes. I thought a small module with node_helper that could return clients’ ip as a result of REST api call from calendar module.

sdetweil

@MMRIZE and that module calls its own rest call publishes the address in its getDom() result, with id= on div

and then cal module can use synchronous document.getElementsById()

to get that value.

sdetweil

@MMRIZE @Spinster

so the little module is

https://github.com/sdetweil/getip

and it does correctly return the ip address of the client… tested from 4 different systems to the same MM…

see later post for final solution

Spinster

@sdetweil @MMRIZE

Wow, you are quick, you have given me some homework. Will use your code and get back with the result.

Thank you so much for your patience and understanding.

Spinster

@sdetweil

I tried your code, but find that once I include getip module in config.js, I am not seeing any output for calendar. Is this the expected output. Without getip module, I find that client_ip = document.getElementById("getip is returning null.Please advice

sdetweil

@Spinstersee later post

MMRIZE

@Spinster
By the way, which client are you using? Electron? Or Browser?

Spinster

@MMRIZE Browser as of now.

I also tried using express ipfilter, but the problem is I don’t know how to use it in module.js, it is throwing error saying ipfilter not known etc

sdetweil

@Spinster well, here is a working example, in addition to the other code already

watch out if using address AND MM host system not included. as it won’t show either…
one could make the ipaddress in cal a list (of ip addresses) similar to what @MMRIZE does…
I don’t like adding the extra block,
just add the var to the thing that matters…

see later post

MMRIZE

@Spinster
With getip of @sdetweil and MMM-ModuleMonkeyPatch, I did it. (You don’t have to modify the original source code for future-proof.)

Example.
Server is running on 192.168.178.63 and I run 2 clients on 192.168.178.22 and 192.168.178.63.
Both 2 clients can show different set of calendars.

windows.192.168.178.22.png

{
	module: "MMM-ModuleMonkeyPatch",
	config: {
		patches: [
			{
				module: "calendar",
				method: "socketNotificationReceived",
				patch: async function (original, args) {
					const [ notification, payload ] = args
					if (notification === "CALENDAR_EVENTS") {
						const calendarName = this.config.calendars.find((cal) => cal.url === payload?.url)?.name
						const r = await fetch('http://192.168.178.63:8080/modules/getip')
						const ip = JSON.parse(await r.text())?.[ 'address' ] ?? null
						if (!this.config.clientMap?.[ ip ]?.includes(calendarName)) {
							return original(notification, { ...payload, events: [] })
						}
					}
					return original(notification, payload)
				}
			}
		]
	}
},
{
	module: "getip",
},
{
	module: "calendar",
	header: "US Holidays",
	position: "top_left",
	config: {
		clientMap: {
			"192.168.178.63": [ "cal1", "cal2", "cal3" ],
			"192.168.178.22": ["cal3", "cal4", "cal5"]
		},
		calendars: [
			{
				url: "...",
				name: "cal1",
			},
			{
				url: "...",
				name: "cal2",
			},
			{
				url: "...",
				name: "cal3",
			},

			{
				url: "...",
				name: "cal4",
			},
			{
				url: "...",
				name: "cal5",
			}
		]
	}
},

TO Improve
Whenever notification CALENDAR_EVENTS coming, getip is called. After first execution, to store IP on the localStorage or cookie would be better.

Spinster

@sdetweil will express ipfilter be useful? Similar to whitelist, can we try something

sdetweil

@Spinster no… as its in the wrong place… (inside node_helper…) we NEED the ip address to compare with

just get it and return . one time

sdetweil

@MMRIZE said in Show calendar based on IP Address accessed:

(You don’t have to modify the original source code for future-proof.)

BUT you are fetching cal for system not going to use it… SOME cals are 1000’s of entries especially old
that have to be processed… this is a bad waste of resources…

and this exposes a cal problem, as if u fetch http://xyz on client 1 and client 2 and client 3, we fetch it 3 times. also bad
this could also lead to different clients showing different data between fetchIntervals…

MMRIZE

@sdetweil said in Show calendar based on IP Address accessed:

BUT you are fetching cal for system not going to use it… SOME cals are 1000’s of entries especially old
that have to be processed… this is a bad waste of resources…

I Can’t understand your point.
My code is just small injection that does filtering out calendars by condition on socketNotificationReceived. No additional fetching is needed.