Version 2.30.0 weather module, stuck loading, worked fine before upgrade

angeliKITTYx

@sdetweil After 24 hours, I’m still stuck at “loading…” could you confirm if I have the config set up properly? I signed up for the Onecall 3.0 API subscription, and it says it’s active.

		{
			module: "weather",
			position: "top_left",
			config: {
				weatherProvider: "openweathermap",
				apiVersion: "3.0",
				type: "forecast",
				weatherEndpoint: "/forecast",
				lat: "xxx",
				lon: "-xxx",
 				apiKey: "cxxx",
				roundTemp: true,
				showPrecipitationAmount: true,
				tableClass: "medium",	
				colored: true,
			}
		},
		{
			module: "weather",
			position: "top_right",
			config: {
				weatherProvider: "openweathermap",
				apiVersion: "3.0",
				type: "current",
				weatherEndpoint: "/weather",
				lat: "xxx",
				lon: "-xxx",
 				apiKey: "cxxx",
				showWindDirectionAsArrow: true,
				showSun: false,
				roundTemp: true,
			}
		},

sdetweil

@angeliKITTYx said in Version 2.30.0 weather module, stuck loading, worked fine before upgrade:

  		apiVersion: "3.0",
  		type: "forecast",
  		weatherEndpoint: "/forecast",

for apiVersion 3.0, you can ONLY use /onecall as the endpoint

those endpoints /forecast, /… are only good with the old 2.5 apiVersion

angeliKITTYx

@sdetweil not going to lie, but I don’t see anywhere saying we have to use /onecall as the endpoint, but that worked for me for both of my current and forecast modules. The location is stating my time zone city (which is 8 hours north) , but the information seems to be correct when comparing it to a weather website. Thank you for the help.

sdetweil

@angeliKITTYx openweather only provides /onecall in v3.0
that is why the default is 3.0 and /onecall

you don’t have to specify them since this release

location? where do you see that?

angeliKITTYx

@sdetweil screenshot

you can see on the right module it says “America/New_York” which is my timezone city, but my lat/lon is set to my home many states south. They used to both say that, but I added the “appendLocationNameToHeader” parameter to the left one to see what it would look like.

Before the API update, it would properly display my home city. I’m pretty sure it’s displaying the correct weather information, but we surprisingly have similar weather to NY right now so it’s hard to confidently confirm.

sdetweil

@angeliKITTYx yes, new openweather api does not return the location info anymore. so you have to add
appendLocationToHeader: false
and add your own header

i will add that info to the top entry as well

angeliKITTYx

@sdetweil yeah that’s what I ended up doing. Thank you again for all your help the last few days! Glad to have everything back to normal.

Richard238

Ran the update, weather module failed , read this thread and can now have either weather or forecast. Can we no longer have both, like before?

sdetweil

@Richard238 two instances, type: as appropriate. NO endpoint setting. The v3 openweather api only supports /onecall (already set as default)
https://forum.magicmirror.builders/post/123079
The config.js.sample shows two instances

Richard238

@sdetweil said in Version 2.30.0 weather module, stuck loading, worked fine before upgrade:

ionToHeader: false

default config sample works, but that’s using openmeteo, not openweathermap, is that correct?

		{
			module: "weather",
			position: "top_right",
			config: {
				weatherProvider: "openmeteo",
				type: "current",
				lat: 40.776676,
				lon: -73.971321
			}
		},
		{
			module: "weather",
			position: "top_right",
			header: "Weather Forecast",
			config: {
				weatherProvider: "openmeteo",
				type: "forecast",
				lat: 40.776676,
				lon: -73.971321
			}
		},
		{

openweathermap.js I have as

		apiVersion: "3.0",
		apiBase: "https://api.openweathermap.org/data/",
		// weatherEndpoint is "/onecall" since API 3.0
		// "/onecall", "/forecast" or "/weather" only for pro customers
		weatherEndpoint: "/onecall",

sdetweil

@Richard238 leave off those parms. Defaults to 3.0 etc

Just put in your 3.0 apikey and lat/lon
And of course set the provider

Richard238

@sdetweil said in Version 2.30.0 weather module, stuck loading, worked fine before upgrade:

leave off those parms.

Which ones, sorry?

sdetweil

@Richard238 all the openweather ones you showed

Richard238

@sdetweil

This gives the ‘undefined, invalid date’ error on the MM

		{
			module: 'weather',
			header: 'Current xxxxxxxxxxxxxxx  weather: ',			
			position: 'top_right',
			config: {
				weatherProvider: "openweathermap",
				lat: 11111111, 
				lon:   2222222,
				apiKey: "33333333333"

			}
		},

sdetweil

@Richard238 and you used real lat/lon

Richard238

@sdetweil

Yes, real Lat:Lon used

Richard238

@sdetweil

Do the L:L and API key live in the openweathermap.js file, or the config.js file? Or both?

sdetweil

@Richard238 all config goes in config.js
Never need to edit any other file

Richard238

@sdetweil

openweathermap.js is unchanged

WeatherProvider.register("openweathermap", {


	providerName: "OpenWeatherMap",

	// Set the default config properties that is specific to this provider
	defaults: {
		apiVersion: "3.0",
		apiBase: "https://api.openweathermap.org/data/",
		// weatherEndpoint is "/onecall" since API 3.0
		// "/onecall", "/forecast" or "/weather" only for pro customers
		weatherEndpoint: "/onecall",
		locationID: false,
		location: false,
		// the /onecall endpoint needs lat / lon values, it doesn't support the locationId
		lat: 0,
		lon: 0,
		apiKey: ""
	},


config.js shows

	{
		module: 'weather',
		header: 'Current zzzzzzzzzzzzzzzz  weather: ',			
		position: 'top_right',
		config: {
			//weatherProvider: "openweathermap",
			providerName: "OpenWeatherMap",
			type: "current",
			lat: nnnnnnnnnnn,
			lon: -nnnnnnnnnnnnn,
			apiKey: "aaaaaaaaaaaaaaaaaaaaaaaaaaa"
			//type: 'current',
			//location: 'xxxxxxxxxxxxxx',
			//locationID: 'zzzzzzzz',  //ID from https://www.openweathermap.org
			//apiKey: 'aaaaaaaaaaaaaaaaaaaaaaaaaaa'
		}
	},

sdetweil

@Richard238

providerName: “OpenWeatherMap”

That is not the correct property name

From the doc
https://docs.magicmirror.builders/modules/weather.html#usage