MMM-FRITZ-Box-Callmonitor-py3 and MMM-Callmonitor-Current-Call

sdetweil

@xIExodusIx thanks, very helpful info…

I will explain a couple things for you, help terminology

usually when you want to make changes to a fellow contributor module , on their module page in the upper right is a button marked fork (here from MMM-RemoteControl module page, mouse pointer over the fork button)

this does two things

gives you a COPY
LINKS your copy to the source of the fork… this LINK allows you to SUGGEST to the author you have change they might like to consider adding… if they PULL it from your copy.

then after having made the copy, you download it just like any other module,
git clone xxxurl

git CLONE does all the file download AND updates the linkage in the cloned repo to point to its origin (where did it come from),
git remote -v
will show you where any repositiory came from

this linkage enables you to make changes, commit them to the local source code repository (hidden in the .git folder) and PUSH those changes UP to the linked repo (IF you have push permission, which you DO on your fork, but do NOT Have on the original repo)

now back to your problem

as you merged three repos, this isnt really FROM any one source, (and isn’t a fork)
but we have two choices

consider it all new. with no prior history
add it to the history where you got the first folder from

SO, lets do option 2.

git status

in the module folder will show you the state of any changed or new files

if you have untracked (new) files and you do NOT want them in the repo
delete them now

til git status shows JUST the changed files and any NEW files you added and need to be there for the module to work

once git status shows correctly do
git add .
(. means all files modified and new)
then git commit -m “whatever message you would like to be recorded in the history about these changes”

do all this, and then post again and we’ll do the step to get it to github

xIExodusIx

@sdetweil
Hello sdetweil,
when I do the first 2 points all is good, but when I do git clone “mycopyurl” I get the error:
Fatal: Target path ‘MMM-FRITZ-Box-Callmonitor-py3’ already exists and is not an empty directory.
I tried also to delete the (my Master Branch?, because it is only a few Minutes old) Master Branch but that won’t work either.

I think it’s my bad english, :-( Sorry for that. :-(

sdetweil

@xIExodusIx you did not need to fork now… I was just explaining , but
you cannot have two folders with the same name,
so you could
rename your current folder,
git clone the fork,
and copy the files from your old renamed folder to the new cloned folder
then
git add
git commit
git push

if you have trouble with english, post in your native language and I will use a translator to help…

also the page can usually be translated for you from my english
in chrome is under the 3 dots menu to the right of the address fields

xIExodusIx

@sdetweil

I’m commig up to “git push” asking for my username followed by my password, but then i got an error because of: Support for password authentication was removed on August 13, 2021.
Why everything must be made so complicated. There’s no fun. :-( Nothing is smooth and easy anymore. :-(
I should authenticate now with a “Personal-Access-Token”. I don’t own one.
To create a “Personal-Access-Token” I have to go to my Organization, I have no Organization, I’m a private person that tries to have a little fun with a MagicMirror2 and some other Raspberry Pi projects.
When I create an Organization and then following the instructions to create Personal-Access-Tokens, no Tokens were created.
Sorry, for today I had enough problems, will try tomorrow again.

sdetweil

@xIExodusIx yes, everybody is getting more serious about security in WAY too many different ways

for github, read the doc on my backup/restore tools
https://github.com/sdetweil/MagicMirror-backup-restore

sdetweil

@xIExodusIx

you can also save the settings for git
see
https://forum.magicmirror.builders/post/124488

xIExodusIx

@sdetweil

Sorry sdetweil, on my github account site at “Password and authentication” is no “developer settings”.
What I can see is;
Password and a button with Change Password
Passkeys and somthing toadd and modify them.
Two-factor authentication! with a bunch of settings.

But no “developer settings”.

sdetweil

@xIExodusIx its moved, select settings, then at the bottom

xIExodusIx

@sdetweil

Okay I hav now a “Personal-Access-Token” but the next problem is comming up afet I make “git push”
Problem:
remote: Permission to xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git denied to xIExodusIx.

It’s really complicated and frustrating :-(

What have I to do now? I searched for permissons on github to modify for uploading but could not find anything.

sdetweil

@xIExodusIx show output of

git remote -v

xIExodusIx

@sdetweil

git remote -v
origin https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git (fetch)
origin https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git (push)

That is what I get.

sdetweil

@xIExodusIx you did use the token as the password, right?

xIExodusIx

@sdetweil

Yes, when I type git push, I have to type in my username and next I have to type in the “userpassword” for that I take the “Personal-Access-Toke” I got from github.

Thats what I do:
git push
Username for ‘https://github.com’: xIExodusIx
Password for ‘https://xIExodusIx@github.com’:
remote: Permission to xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git denied to xIExodusIx.
Schwerwiegend: konnte nicht auf ‘https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git/’ zugreifen: The requested URL returned error: 403

The Problem is, that the “password” aka “Personal-Access-Token” is not showed in Linux (RaspiOS). I copy the “PAT (Personal-Access.-Token)” that I stored in Keepass on my PC and insert it using a klick with the right mouse-button in RaspiOS.

xIExodusIx

@sdetweil

I got it, I made a new “Personal-Access-Token (classic)” giving it write access permissons for repositories and could now successful make “git push”.

xIExodusIx

@sdetweil

What have I to do next?
Can I edit my commit? I would like to give mor information and correct some typing errors.

sdetweil

@xIExodusIx no , cannot edit a “commit”

you can make another

change files
test
git status
git add
git commit
git push

same workflow each time

xIExodusIx

@sdetweil

okay :-)

Thank you very, very much for your help.

rkorell

Dear @xIExodusIx ,
do you think it’s possible to get your re-compiled code?
I’m really curious - because the current call monitor is “nice” but the improvements you had described seemed to be really promising…

Thanks a lot.
Warmest regards,
Ralf

xIExodusIx

@rkorell

Hi Ralf,
if you search within the MM2 modules for “armybean” and find the module “MMM-Callmonitor-Current-Call” click on the right side in the description on “MMM-FRITZ-Box-Callmonitor”.
On the next screen click on the right side on “25 Forks” there you will find my Fork “xIExodusIx / MMM-FRITZ-Box-Callmonitor-py3”.
You can “git clone it” using “git clone https://github.com/xIExodusIx/MMM-FRITZ-Box-Callmonitor-py3.git” in the /MagicMirror/modules folder. That should do all for you. After that follow th instrucktions given by “Paviro or Dr.Torchwood” they are almost the same.
I havs only merged the Versions from Paviro and armybeen and drtorchwood together, I did not compile the module new. Paviro did the aase Module, armybean added the (colored) direction arrows and drtorchwood made the module work with python3.
If you wnt to have the colored direction arrows you have to add “showOutgoing: true, and colorEnabled: true,” at the modulesection “MMM-FRITZ-Box-Callmonitor.py” in the /MagicMirror/config/config.js. Same if you use armybeans “MMM-Callmonitor-Current-Call”.
I hope this is understanding for you.

Have fun with it.
Carsten

rkorell

@xIExodusIx said

Have fun with it.

Dear Carsten, indeed - I DO have fun!

It’s really, really nice and works like a charm!
Thanks a LOT for your great work.

For future releases (if I interpret the above thread and Sam’s (@sdetweil 's) hints and advices correctly) you can edit the “README.md” file locally in your directory.
There you can include your own input/changes and own hints for installing (e.g. correct the git clone-link) - and AFTER these changes in documentation do the git push-thing …

Thank you very much for your effort!

Warmest regards,
Ralf