Read the statement by Michael Teeuw here.
MMM-CEC-Control (tv remote via HDMI-CEC)
-
@Sn4Pz That’s cool :-D
Don’t forget to add it to the module list: https://github.com/MagicMirrorOrg/MagicMirror/wiki/3rd-party-modules
-
@KristjanESPERANTO to be honest with you I am not sure it respects the standard code etiquette MM expects of it’ modules.
Is there someone who can curate it, and take care of it better? :) -
@Sn4Pz If your module works and may be useful for more people than you, it qualifies for the list. MagicMirror is a community project, and many module developers are not programmers - the quality (measured against professional programming standards) of some modules reflects this. But that’s not a problem; MagicMirror is a project to learn and tinker 😃 If someone finds an issue in your module, they can address it or even create a PR to improve it. That is one of the huge advantages of open source.
As soon as you add your module to the list, a few automatic tests will be ran (within 24 hours), resulting in a list of recommendations - but following these is entirely optional.
-
… and following those recommendations allows you to learn better code and improve!
-
Thanks for the feedback guys,
I will try and add it to the list on monday :)
Hope this will help someone else out there :)
