Calendar events broadcasting, nothing showing...

[sdetweil]

@BKeyport hmmm. I think the caching might be affecting

Comment out these lines in calendar.js

[KristjanESPERANTO]

I tracked this down to a likely root cause: after the HTTPFetcher 304 change, some consumers were trying to process empty responses. In PR #4180, I fixed that for calendar and other consumers.

[BKeyport]

@sdetweil does not seem to affect anything.

            if (notification === "CALENDAR_EVENTS") {
                        // have we received events for this url
                        if (!this.calendarData[payload.url]) {
                                // no, setup the structure to hold the info
                                this.calendarData[payload.url] = { events: null, checksum: null };
                        }
                        // save the event list
                        this.calendarData[payload.url].events = payload.events;

                        this.error = null;
                        this.loaded = true;

                        if (this.config.broadcastEvents) {
                                this.broadcastEvents();
                        }
                        // if the checksum is the same
/*
                        if (this.calendarData[payload.url].checksum === payload.checksum) {
                                // then don't update the UI
                                return;
                        }
*/
                        // haven't seen or the checksum is different
                        this.calendarData[payload.url].checksum = payload.checksum;

[sdetweil]

@BKeyport thanks… I see an other change submitted today

https://github.com/MagicMirrorOrg/MagicMirror/pull/4180
which references this topic

if you want to try that do

cd ~/MagicMirror
# restore calendar.js 
git checkout defaultmodules/calendar/calendar.js
git fetch origin pull/4180/head:_fix_304
rm package-lock.json
git switch _fix_304
npm run install-mm
restart MM

[BKeyport]

@sdetweil That fixed it here.

[sdetweil]

@BKeyport awesome!! Thanks for the feedback

[BKeyport]

@sdetweil When we get to the quarterly update, I’ll need to know how to update back to the main. LOL

[sdetweil]

@BKeyport yes. If you use my upgrade script it will move you back to the mainline, or I’ll give you instructions

[BKeyport]

@sdetweil oh, cool that you built that in the scripts - I use that.

[sdetweil]

@BKeyport yes, if I discover you are not on the master branch, I move you to master, then update from there.

For exactly this situation. Trying a specific fix or all of develop branch.