Input...What do you think?

Snille

@cowboysdude Hmm… I forgot a “comma” on the

en: "translations/en.json"

line… Sorry…
should be:

en: "translations/en.json",

And then it seems to be missing something else…
I get this error…

Uncaught TypeError: Cannot read property 'simpleforecast' of undefined
    at Class.processNoaa (MMM-NOAA.js:58)
    at Class.socketNotificationReceived (MMM-NOAA.js:88)...

But I have to go to bed… REALLY now… :)

Mykle1

@Snille said in Input...What do you think?:

But I have to go to bed… REALLY now… :)

It’s early! And it’s Friday night!
(Yes, I know, it’s Saturday morning for you.)

12:46 AM
Friday, July 28, 2017 (GMT+2)
Time in Sweden

cowboysdude

@Snille Thank you I changed it and THANK YOU FOR NOTICING… I also discovered that I left my api key in the main.js file…ughhhhhhhhhhh had to change that too. I know I was tired when I posted this on github… hahahahhaah

cowboysdude

@Snille What did you use for location?

Like I use NY/Elmira

We have to see if your location is working…

cowboysdude

@Snille said in Input...What do you think?:

@cowboysdude Hmm… I forgot a “comma” on the
en: "translations/en.json"
line… Sorry…
should be:
en: "translations/en.json",
And then it seems to be missing something else…
I get this error…
Uncaught TypeError: Cannot read property 'simpleforecast' of undefined
    at Class.processNoaa (MMM-NOAA.js:58)
    at Class.socketNotificationReceived (MMM-NOAA.js:88)...
But I have to go to bed… REALLY now… :)

It doesn’t recognize your location :(

Mykle1

@Snille

“250,000+ personal weather stations across the globe already send data to Weather Underground!”

Not a single one in Sweden, according to https://www.wunderground.com/weatherstation/ListStations.asp?selectedCountry=Sweden

cowboysdude

@Mykle1 said in Input...What do you think?:

@Snille

“250,000+ personal weather stations across the globe already send data to Weather Underground!”

Not a single one in Sweden, according to https://www.wunderground.com/weatherstation/ListStations.asp?selectedCountry=Sweden

That’s NO GOOD.

Mykle1

@cowboysdude

@Snille’s next project? :-)

cowboysdude

@Mykle1 OH wait don’t I have like 2 other weather modules I made and NEVER released? Perhaps I can salvage one of those… hummmmmmmmmmmmm

Mykle1

@cowboysdude

We don’t want the other ones. We want this one!

Make it work! :-)

cowboysdude

Thanks to Mykle we’ve changed the api call and NOW it should cover just about the entire world … well if you have a pws close by you :)

Thanks to @Snille and @Mykle1 for their help… like I said didn’t plan on releasing this and honestly only asking for what others thought of it but hey looks like once the bugs are all ironed out it’ll be coming to a mirror near you…

barnosch

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.

show: "F".toLowerCase(), // show F or C Temps

Mykle1

@barnosch said in Input...What do you think?:

Guess your are still in the middle of development.

You don’t have to guess. All you have to do is actually read what he wrote in the post above yours. :-)

cowboysdude

cowboysdude

@barnosch said in Input...What do you think?:

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.
show: "F".toLowerCase(), // show F or C Temps

In your config.js file at the top…

    ```timeFormat: 12,  // change that to a 24 ;) ```

cowboysdude

Hot off the presses … Swedish translation :) Thanks again @Snille

[If anyone would be kind enough to do the German translation I’d appreciate it!! PM me!]

cowboysdude

@barnosch said in Input...What do you think?:

Looks very nice.
The german translation seems to be wrong ;) and not even added to the MMM-NOAA.js
Guess your are still in the middle of development.
Added it myself but it is not working yet.
Also i would like a 24hours setting, if possible.

Thansk for your work

PS: is this correct in the default settings? Guess not.
show: "F".toLowerCase(), // show F or C Temps

Done… in the config file it’s
format: "12" or "24"

testing

barnosch

Thanks. I already fixed it at my mirror with
(config was already in 24hours mode)
changeing this line

//  time = time.toLocaleString('en-US', { hour: 'numeric',minute:'numeric', hour12: true });
       time = time.toLocaleString('de-DE', { hour: 'numeric',minute:'numeric', hour24: true });

which did the job

And for the sunset and sunrise i just changed to

H:mm

Ugly and hardcoded but worked for me. with my low programming skills.

How is the correct way to update the repository via git? I’m kind of new to this stuff.

Snille

@cowboysdude Ah, Thank you! Looking good. I’ll pull when I have some time. :)

cowboysdude

@barnosch said in Input...What do you think?:

Thanks. I already fixed it at my mirror with
(config was already in 24hours mode)
changeing this line
//  time = time.toLocaleString('en-US', { hour: 'numeric',minute:'numeric', hour12: true });
       time = time.toLocaleString('de-DE', { hour: 'numeric',minute:'numeric', hour24: true });
which did the job

And for the sunset and sunrise i just changed to
H:mm
Ugly and hardcoded but worked for me. with my low programming skills.

How is the correct way to update the repository via git? I’m kind of new to this stuff.

No you did great but I will put in a fix for it and you can do a git pull later :)

Ok the fix is in… the time will automatically read your language in the config.js file and adjust itself accordingly… However you will want to keep your sunrise/sunset ‘fix’ for now because I did not change that. :)