MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Loading compliments from external file

    Scheduled Pinned Locked Moved Solved Requests
    4 Posts 3 Posters 2.8k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • bheplerB Offline
      bhepler Module Developer
      last edited by

      Greetings!

      My mirror project is destined to be a gift for a friend and as part of the configuration for it, my wife and her friends are writing a metric buttload (100+) of compliments. I’m going to have to load those compliments into the compliment module. Which is fine, but I am concerned that if I screw up even one of those compliments, the config.js file will not be a valid file and the MagicMirror interface will not display properly.

      My solution, thanks in no small part to @strawberry-3-141 expert assistance, is to put the compliment arrays into a separate JSON file and load that file as an optional parameter fileName. I have the code ready and it has passed my alpha testing. The fileName parameter is optional and this is an extension of the existing core modules.

      I’d like to add this feature to the core MagicMirror project. Is this a valuable feature? How do I go about contributing a minor change to the core?

      1 Reply Last reply Reply Quote 0
      • KirAsh4K Offline
        KirAsh4 Moderator
        last edited by

        Submit a PR request on the Github page. Do it against the ‘develop’ branch please.

        A Life? Cool! Where can I download one of those from?

        1 Reply Last reply Reply Quote 3
        • bheplerB Offline
          bhepler Module Developer
          last edited by

          Done. Thanks.

          1 Reply Last reply Reply Quote 1
          • T Offline
            tajno
            last edited by tajno

            Nice, I was looking for that feature - thanks for your work bhelper. Good idea! Actually I try to change the color as well, but I wasn’t successfull so far.

            1 Reply Last reply Reply Quote 1
            • 1 / 1
            • First post
              Last post
            Enjoying MagicMirror? Please consider a donation!
            MagicMirror created by Michael Teeuw.
            Forum managed by Sam, technical setup by Karsten.
            This forum is using NodeBB as its core | Contributors
            Contact | Privacy Policy