Sorry if this demontivates anyone, but I thought I should mention it here anyway. I stumbled across a fork of MagicMirror²: https://github.com/hangorazvan/MagicMirror2. Forks are basically not a problem, but the creator rails against MagicMirror² and the developers. I have not seen anything like this before :-(

based on MagicMirror² open source core framework unfortunately full of bugs from amateur “developers”… NO FUCKING THANK YOU FART OLD MAN!

Why is he forking if it’s so bad? And why doesn’t he make pull requests? Has anyone seen a pull request from him? Can he do that with the other license?

Ah, I didn’t know --single-branch yet. But yes, that sounds reasonable too.

Optimizing both (git clone and npm install) would speed up the setup process, especially on slow machines. Since a simple user just copies the commands from the documentation, these changes wouldn’t complicate the process any further.

That’s interesting, but I’m talking about the official documentation here :-)

What do you think about adding --depth=1 to git clone in the documentation?

Like this: git clone --depth=1 https://github.com/MichMich/MagicMirror

This would have the positive effect that users would only have to download 437 KiB instead of 19 MiB. The whole git history is not relevant for normal users, is it?

Okay, thanks for your opinions. I’ll use npm ci for a while with my instances to gain more experience.

I mark this thread as solved for now. Further opinions are of course welcome.

@Aldarande has already created a PR to this problem:
https://github.com/BenRoe/MMM-SystemStats/pull/50

You could use his/her fork for now until the PR is accepted:
https://github.com/Aldarande/MMM-SystemStats

@kusselin said in Carousel is not working:

another question I have: udn namely when the modules change it can be that these are very “WIDE” at once…at the repeated change then again normal in the width become…woran lies this? can that be?

Does this also happen with the new fork I recommended?

many developer don’t know what is package.json file

Isn’t that one of the first things you learn when you start using npm? :-)

this command need package-lock.json

Yes, of course. And the core system has the package-lock.json. I was not talking about modules. Sorry if that was not clear.

What do you think about switching from npm install to npm ci?

I’m not an npm/node expert, but my understanding is that there could be some advantages.

If we use npm ci, we’ll get reliable builds. Users who install a release get exactly the versions that worked on the release.

barnabycolby did’t update the module since 5 years. I recommend to use a newer fork. Like this one: https://github.com/shbatm/MMM-Carousel/

The following config should work with the new fork:

     {
            module: 'MMM-Carousel',
            config: {
                transitionInterval: 40000,
                ignoreModules: ['clock', 'alert', 'MMM-Tools', 'MMM-OpenmapWeather', 'MMM-PublicTransportHafas', 'weatherforecast', 'calendar', 'newsfeed', 'MMM-Remote-Control', 'MMM-Traffic', 'MMM-Fuel'],
                mode: 'slides',
                slides: {
                    "Slide 1": ['MMM-SoccerLiveScore'],
                    "Slide 2": ['MMM-Formula1', 'MMM-COVID19-AMPEL']
                }
            }
    }