@mart11 This should be fixed since we released version 3.0.0 😀 Please update and check.

for MagicMirror purposes, is there a preferred style to be used for modules?

@kayakbabe I agree with Sam, but here’s a more detailed answer anyway: This depends on where you are. In some modules there are no rules for this - there and in your own modules it is, as Sam says, up to you.

However, to avoid poor code style, such as spaghetti code and inconsistently formatted code, which not only make maintenance and further development more difficult, but also affect team collaboration, many projects use static code analysis tools such as prettier and ESLint for checking code quality.

In the MagicMirror core (and with this in the default modules), we use the ESLint object-shorthand rule (see https://archive.eslint.org/docs/rules/object-shorthand) to ensure that only the shorthand version is used.

@kayakbabe said in Syntax Style for node_helper.js:

I see both ways done in node_helper.js in different modules.

The short variant is known as “Shorthand Method Names” and has been available since 2015 (with the release of ECMAScript 6).

https://ui.dev/shorthand-properties#shorthand-method-names

@Chloe282 Nice job! 👏 Thanks for sharing 😀

@Klinge MMM-Universal-Pir seems to be the newest. Have you checked that?

@mmmmh MMM-ISS-Live has a mute option.

@sdetweil said in MMM-FRITZ-Box-Callmonitor-py3 unknown_error:

i do not know how the module works but i suspect this
https://forum.magicmirror.builders/post/123380

Where do you see the connection? The maintainer of MMM-FRITZ-Box-Callmonitor-py3 is drtorchwood.

@rkorell It would be best if someone could be found who is willing to maintain the module. The module is open source, so the work could continue in a fork.

@chrisfr1976 Great. I have just adjusted the list in the wiki accordingly :-)

@chrisfr1976 Nice work! Since there are much older unresponded Pull Requests, I suggest to replace the original module with your fork on the module list. If the upstream project gets active again, we can undo that change in the list. What do you think?