@mumblebaj nope all good was just making sure I wasn’t missing current news.

The bottom right of where the news was sourced from is always 1 day ago is that accurate to they way it should be?

https://github.com/jclarke0000/MMM-OpenWeatherForecast

@sdetweil ctrl m worked thanks Sam!

@sdetweil You are the man worked like a charm. Only thing I noticed when running on windows “alt” does not bring the toolbar up in order to quit MM. Did anything change?

@sdetweil Here ya go
https://drive.google.com/file/d/1L5ORoBJlEV6lYSLzJC7VhHM1S1P-jRWy/view?usp=share_link

@sdetweil said in After update 2.23.0 crash:

@swvalenti nope it wont work as it is… looks only in the node_helper… oops…

working on fix…

pushed a fix

Ran upgrade script but still didn’t work same error

@sdetweil said in After update 2.23.0 crash:

@swvalenti should…

Thanks Sam I’ll report back

@sdetweil said in After update 2.23.0 crash:

@swvalenti the script DID catch for request, but not jsdom…

these are the undocumented libs used

OWGR.js:const request = require('request');
OWGR.js:const jsdom = require("jsdom");

I just added that to the upgrade script list of missing libs

Cool so if I update it will work?

@sdetweil said in After update 2.23.0 crash:

@swvalenti got it…

Thought maybe the script would catch it. Ha. Oh well thanks for all your help and work.

@sdetweil said in After update 2.23.0 crash:

@swvalenti how did you revert?

Copied original file and renamed before using your script.

@swvalenti said in After update 2.23.0 crash:

@JerryP said in After update 2.23.0 crash:

@sdetweil

pi@raspberrypi:~/MagicMirror $ ls
 CHANGELOG.md   Collaboration.md   core  'DISPLAY=:0'   index.html   jest.config.js   jsconfig.json   magicmirror@2.23.0   module-types.ts   oud         run-start.sh   splashscreen   th.json        vendor
 clientonly     config             css    fonts         installers   js               LICENSE.md      modules              node_modules      README.md   serveronly     tests          translations
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/pi/MagicMirror/node_modules/acorn
npm ERR! dest /home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/pi/MagicMirror/node_modules/acorn' -> '/home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_43_20_803Z-debug-0.log

That didn’t work, no worries I will revert

The package.json showed no issue with that command. It worked when I reverted no issue.

@JerryP said in After update 2.23.0 crash:

@sdetweil

pi@raspberrypi:~/MagicMirror $ ls
 CHANGELOG.md   Collaboration.md   core  'DISPLAY=:0'   index.html   jest.config.js   jsconfig.json   magicmirror@2.23.0   module-types.ts   oud         run-start.sh   splashscreen   th.json        vendor
 clientonly     config             css    fonts         installers   js               LICENSE.md      modules              node_modules      README.md   serveronly     tests          translations
pi@raspberrypi:~/MagicMirror $ npm install
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /home/pi/MagicMirror/node_modules/acorn
npm ERR! dest /home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig
npm ERR! errno -39
npm ERR! ENOTEMPTY: directory not empty, rename '/home/pi/MagicMirror/node_modules/acorn' -> '/home/pi/MagicMirror/node_modules/.acorn-pnTZ3fig'

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2023-04-04T20_43_20_803Z-debug-0.log

That didn’t work, no worries I will revert

@sdetweil said in After update 2.23.0 crash:

@swvalenti yes, there is no package.json describing the dependencies…

some of the local add on scripts use request and jsdom and others…

So I should revert back to 2.22 then?

Don’t want to hijack but didn’t want to create another thread. MM doesn’t run after upgrade with this error. I think it is related to MMM-PGA module but not sure what changed as dev window won’t run either.

[04.04.2023 16:29.46.158] [ERROR] (node:11188) UnhandledPromiseRejectionWarning: Error: Cannot find module 'jsdom'
Require stack:

@ilikestuff open weather forecast has the same

Honestly I would just use

https://github.com/jclarke0000/MMM-OpenWeatherForecast

Just disable the MM default weather module and use Netatmo

Just tried it on mine no issues and no npm install

@Anthony not sure if this is related but I see you are cloning into moon phase. That folder shouldn’t exist yet and should be cloning into modules folder instead. I can’t see your commands before that to make sure that’s what you’ve done.