Internet Monitor

sdetweil

installer/preinstall.sh

the problem is under windows, this path is bad as it doesn’t have \

unfortunately NPM is NOT platform neutral

you can’t even do it with a .cmd (and bash script without .sh) in the current folder…
as windows would work, but then linux would fail as current folder not in the PATH

I wrote a js file that could be launched on either and launch the right thing

but a pain in the rear

bugsounet

@sdetweil

That why i says :

I’m glad that you use windows 😧
Now retry with your pi, a linux env or … with wsl under windows 😉

bhepler

@bugsounet said in Internet Monitor:

the real question is why using v1.6.2 version of SpeedTest library?

Because using speedtest-net after this version requires a code change.

Now retry with your pi, a linux env or … with wsl under windows

Oh, great. I develop on Windows so I can make use of a proper IDE. Fine. I’ll dig up something.

@sdetweil said in Internet Monitor:

the problem is under windows, this path is bad as it doesn’t have
unfortunately NPM is NOT platform neutral

Sigh. It figures. Not tonight, but I’ll work on it in the near future.

bhepler

Okay, I believe I have it fixed for this module. Please switch over to the 2022-fix branch and give it a pull & install. Let me know if it works for you and I’ll issue a PR.

Big shout out to @bugsounet for figuring it out and from whom I blatantly stole a lot of code. At some point I remembered that this isn’t my module and I’m just trying to get it functioning again. It helped me ignore a lot of things I would have changed.

mayfield

@bhepler Where do you find the update? is this the right link? https://github.com/ronny3050/internet-monitor

bhepler

@mayfield - No. Install from here: https://github.com/BrianHepler/internet-monitor.git

If you have installed from Ronny3050’s repository, you’ll need to delete that folder and clone from mine.

bhepler

I suppose more detailed instructions are in order. To use my development branch of my fork of the internet-monitor module, give this a try.

cd MagicMirror/modules
sudo rm -rf internet-monitor
git clone https://github.com/BrianHepler/internet-monitor.git
cd internet-monitor
switch 2022-fix
npm install

Once it is done, you should be able to use your existing configuration. Let me know if you encounter any problems.

bhepler

My fork of the module has been updated and the new code has been merged to the master branch. Let me know if you hit any issues with it.

ebourne

@bhepler what do you mean by switch 2022-fix?
I am trying to get this module working but it seems the config file example has an error in it or something because when i run the mirror after copy pasting the module array it gives the error page

bhepler

@ebourne I had a branch of the internet-monitor module that I was using to test a fix. Before I merge it into the master branch, I wanted people to try out the fix and give me some feedback. I guess I never got around to deleting it. The master branch had the updates, so it’s not a big deal.

Thanks to @KristjanESPERANTO I have a new fix in place and it has been merged into the master branch. It should be easy to update the module:

get an SSH connection to your mirror.
navigate to the internet-monitor folder
pull the latest updates with git pull
install the changes with npm install

Restart your magic mirror process and it should work again.

Just a quick note: I don’t really maintain this module. I created a fork to get it running a long time ago after the author abandoned it. I try to help out from time to time, but this is not one of my priorities. Hence, the README file and example configuration are a bit of a mess.