Automatic checking of all MagicMirror² modules

karsten13

from your todo list

Is there also a GitLab API?

yes, as example you can look at MMM-RepoStats

Another thing is what the source of the list should be, still the wiki (which is very error prone since anyone can edit things).

Alternatively, you could store a list in your repo and we need something for users to add to their repo (e.g. as a PR in the repo or with website functionality).

But maybe there are even better ideas.

Jalibu

hmm… if this is the cornerstone for a proper MagicMirror Appstore, then I should consider renaming all my modules to start with the letter “A” to attract more attention on the landing page :-D

MMRIZE

@Jalibu Didn’t do that yet? :D

BKeyport

@Jalibu AAA-Module instead of MMM? 🤣🤣🤣🤣

Jalibu

@BKeyport or MMM-a-fancy-weather-module, MMM-a-powerful-stock-ticker, MMM-a-bosch-smart-home-dashboard, etc…

KristjanESPERANTO

@Jalibu said in Automatic checking of all MagicMirror² modules:

hmm… if this is the cornerstone for a proper MagicMirror Appstore, then I should consider renaming all my modules to start with the letter “A” to attract more attention on the landing page :-D

Yeah, I’m already have some ideas about the default sort order (like a combination of stars, issues and activity), this will prevent that :beaming_face_with_smiling_eyes:

KristjanESPERANTO

In the last few days I have worked on some details on the site. So if you’re interested, take a look: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/.

And there is now a little statistics table on the results page: https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#statistics

I have also created a few PRs based on the list for some modules. Most of them have already been accepted :-)

mumblebaj

@KristjanESPERANTO Looks good. Just out of interest, which image does it select as the thumbnail? Just noticed 2 of the modules of mines does not have the correct images. Both Growatt modules are the ones I am referring to.

mumblebaj

@KristjanESPERANTO Stats were great, fixed most of the issues identified in my modules. Majority package.json issues.

Great work @KristjanESPERANTO

sdetweil

@KristjanESPERANTO

could we separate out the cosmetic issues (MagicMirror vs the one with the superscript 2, as I don’t know how to make that happen in my text editor…) and its useless

and this is misleading

MMM-AareGuru by buge
There is no package.json. We need this file to gather information about the module.

there is no need for a package,json… as this module does all its work inside the modulename.js
there is no functional requirement as there is no node_helper.js

sdetweil

@KristjanESPERANTO
additionally… a module I forked was marked as present and attributed to me, but I never posted it… MMM-Alexa (and I deleted it from your list… and it is NOT present in the master list )

and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it

MMM-SleepWake.

KristjanESPERANTO

@mumblebaj said in Automatic checking of all MagicMirror² modules:

Just out of interest, which image does it select as the thumbnail?

If the script doesn’t find an image with ‘screenshot’ or ‘example’ at the beginning of the name it takes the first it finds .

The prerequisite for the whole thing is that a free license is specified in the package.json. If there is no package.json and no free license, no image will be searched.

Stats were great, fixed most of the issues identified in my modules.

Nice, thank you! I just updated the list and a lot of issues disappeared 👏

@sdetweil said in Automatic checking of all MagicMirror² modules:

I don’t know how to make that happen in my text editor

On my keyboard it’s just +

and its useless

I think it’s worth striving to call things by their proper names, so I don’t find the test useless. Feel free to just ignore it :-)

there is no need for a package,json… as this module does all its work inside the modulename.js there is no functional requirement

You are right, functionally there is no need for this. However, the file is a good source of information that is interesting for the website - e.g. keywords.

MMM-Alexa

Do you know if the original module (https://github.com/sakirtemel/MMM-alexa) still works? Otherwise I should mark it as outdated.

and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it. MMM-SleepWake

I’ve added it now :-)

sdetweil

@KristjanESPERANTO I have no info on MMM-Alexa or why i forked it

KristjanESPERANTO

@sdetweil said in Automatic checking of all MagicMirror² modules:

and this is misleading

There is no package.json. We need this file to gather information about the module.

I added ‘for the website’ at the end of the sentence. I hope that this is clearer.

Thanks for the feedback :-)

sdetweil

@KristjanESPERANTO I have no website.

KristjanESPERANTO

@sdetweil Yes, I mean this website: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/. Information from the package.json files is used there.

BKeyport

@KristjanESPERANTO “This” instead of “The” perhaps?

KristjanESPERANTO

@BKeyport Good suggestion :-) But what do you think of this:

No keywords in 'package.json'. We would use them as tags on the module list website.

BKeyport

@KristjanESPERANTO Kinda awkward, honestly.

KristjanESPERANTO

@BKeyport Sorry, I tend to use the logic of my native language in my English sentences 😅