Read the statement by Michael Teeuw here.
Need help for rewrite node_helper.js from 'request' to 'got'
-
@sdetweil
As far as I can see this works the correct way.
Do you agree? -
@htilburgs depends on what you mean by correct.
it returns the parsed text as an object
not text. -
@sdetweil
That I don’t understand.
Is this a problem? What would be better? -
@htilburgs the response.json() function returns a js object already parsed.
thst is what yiy were going to fo w JSON.parse(). but don’t need to.
I don’t know if the CONTENT of the object is correct, but it should be for the same request
-
@sdetweil
In the previous version with ‘request’ I used JSON.parse() and got the same results.
The module works, but I didn’t know for sure if I used the correct approach. -
@htilburgs if you push the repo I’ll look at it… you can do it on a separate branch to not disturb the existing
-
@sdetweil published it. Didn’t know how than on Master.
-
@htilburgs ok, I’ll look at it first thing in the morning
-
@htilburgs I made a couple changes to the Js and added comments to the node_helper, but all looks ok …
-
@sdetweil
Hi Sam, thanks in advance. I’m not at home right now and I only have my smartphone. I cannot test, but I’ll try it in a day.I’ll let you know!!
