Read the statement by Michael Teeuw here.
Need help for rewrite node_helper.js from 'request' to 'got'
-
@sdetweil
In the previous version with ‘request’ I used JSON.parse() and got the same results.
The module works, but I didn’t know for sure if I used the correct approach. -
@htilburgs if you push the repo I’ll look at it… you can do it on a separate branch to not disturb the existing
-
@sdetweil published it. Didn’t know how than on Master.
-
@htilburgs ok, I’ll look at it first thing in the morning
-
@htilburgs I made a couple changes to the Js and added comments to the node_helper, but all looks ok …
-
@sdetweil
Hi Sam, thanks in advance. I’m not at home right now and I only have my smartphone. I cannot test, but I’ll try it in a day.I’ll let you know!!
-
@htilburgs no rush at your availability.
-
@sdetweil
Sam, you put a comment in node_helper.js.
I don’t understand what you mean.// don’t need this anymore with async below
-
@htilburgs ignore. I tried async didn’t help
-
@sdetweil
;-)
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login