Need help for rewrite node_helper.js from 'request' to 'got'

[htilburgs]

@sdetweil

I kept on searching and think I’ve found it.
I didn’t use JSON.parse(), but simply put it in the result

    this.sendSocketNotification('MPT_RESULT', result.data.timings);

It works, but I hope this is the right way.

[sdetweil]

@htilpburgs I was going to say the result of json() is passed already

[htilburgs]

@sdetweil
As far as I can see this works the correct way.
Do you agree?

[sdetweil]

@htilburgs depends on what you mean by correct.

it returns the parsed text as an object
not text.

[htilburgs]

@sdetweil
That I don’t understand.
Is this a problem? What would be better?

[sdetweil]

@htilburgs the response.json() function returns a js object already parsed.

thst is what yiy were going to fo w JSON.parse(). but don’t need to.

I don’t know if the CONTENT of the object is correct, but it should be for the same request

[htilburgs]

@sdetweil
In the previous version with ‘request’ I used JSON.parse() and got the same results.
The module works, but I didn’t know for sure if I used the correct approach.

[sdetweil]

@htilburgs if you push the repo I’ll look at it… you can do it on a separate branch to not disturb the existing

[htilburgs]

@sdetweil published it. Didn’t know how than on Master.

[sdetweil]

@htilburgs ok, I’ll look at it first thing in the morning

[sdetweil]

@htilburgs I made a couple changes to the Js and added comments to the node_helper, but all looks ok …

[htilburgs]

@sdetweil
Hi Sam, thanks in advance. I’m not at home right now and I only have my smartphone. I cannot test, but I’ll try it in a day.

I’ll let you know!!

[sdetweil]

@htilburgs no rush at your availability.

[htilburgs]

@sdetweil
Sam, you put a comment in node_helper.js.
I don’t understand what you mean.

// don’t need this anymore with async below

[sdetweil]

@htilburgs ignore. I tried async didn’t help

[htilburgs]

@sdetweil
;-)