• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-cryptocurrency - v1.4

Scheduled Pinned Locked Moved Utilities
77 Posts 21 Posters 77.7k Views 25 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • A Offline
    ArkantosArk
    last edited by Sep 2, 2017, 9:32 AM

    Hi @matteodanelli See my module config below. I haven’t changed any module files at all. I’m running it in a Raspberry pi 1, but I don’t think the issue is related with that.

    {
                module: "MMM-cryptocurrency",
                position: "bottom_bar",
                config: {
    	    currency: ['ethereum', 'bitcoin'],
    	    conversion: 'EUR',
                    displayType: 'detail',
    	    headers: ['change24h']
                }
                    },
    
    M 1 Reply Last reply Sep 2, 2017, 9:48 AM Reply Quote 0
    • M Offline
      matteodanelli @ArkantosArk
      last edited by Sep 2, 2017, 9:48 AM

      @ArkantosArk Very strange.
      Same module configuration is working here, even if I set 1h.

      {
        module: "MMM-cryptocurrency",
        position: "bottom_bar",
        config: {
          currency: ['ethereum', 'bitcoin'],
            conversion: 'EUR',
            displayType: 'detail',
              headers: ['change24h', 'change1h']
        }
      }
      

      Is it possible that aren’t conflict with other modules?
      In any case, if you cannot fix, try to re-download module from repository and then re-add in your configuration.
      Let me know if something changes.

      A 1 Reply Last reply Sep 3, 2017, 8:03 PM Reply Quote 0
      • J Offline
        jimador
        last edited by Sep 3, 2017, 9:44 AM

        Re: MMM-cryptocurrency - v1.1
        @matteodanelli great module. I works pretty fine. Thank you for this.

        At the moment we have 3 options to view the change of the currency in 1h, 24h and 7d.
        Can you add an option to view the change since the purchase value?

        Or how I can do this by myself?

        BR

        M 1 Reply Last reply Sep 3, 2017, 2:27 PM Reply Quote 2
        • M Offline
          matteodanelli @jimador
          last edited by Sep 3, 2017, 2:27 PM

          @jimador Hi!
          Unfortunately, it’s not easy to select a custom starting date, because I use an external service which provides me only that history.
          Tracking myself the currency change is expensive and I’ll not do in the next future.
          But, if you know some web services able to do that I’m really happy to implement this feature :)

          1 Reply Last reply Reply Quote 0
          • A Offline
            ArkantosArk @matteodanelli
            last edited by Sep 3, 2017, 8:03 PM

            @matteodanelli Hi have reinstalled the module and keeps showing the same error on the logs:

            modules/MMM-cryptocurrency//MMM-cryptocurrency.js @68: TypeError: undefined is not a function (evaluating ‘this.config.headers.includes(‘change1h’)’)

            It seems that it can be an issue on line 68 on that file. If I copy and paste the content of the file on JSHint.com, it shows me that there is an error on some lines:

            0_1504468978573_Captura de pantalla 2017-09-03 a las 21.02.11.png

            I would love it to have this module on detail mode, but it seems that is only working properly in logo mode for now.

            M 1 Reply Last reply Sep 7, 2017, 9:13 PM Reply Quote 0
            • M Offline
              matteodanelli @ArkantosArk
              last edited by Sep 7, 2017, 9:13 PM

              @ArkantosArk Hey,
              I make a bug fix where you outlined some problems. You can checkout updated code from repository.

              Now you should have the module working in both configuration.
              Let me know.

              Thank you!

              A 1 Reply Last reply Sep 8, 2017, 6:29 PM Reply Quote 0
              • A Offline
                ArkantosArk @matteodanelli
                last edited by Sep 8, 2017, 6:29 PM

                @matteodanelli Hi!

                I can see your update and now JShint doesn’t find any issues. However I still have the same exact issue as my previous post. Can this be a browser related issue? I am using Midori instead of Chrome (cause I’m implementing everything on a Raspberry pi 1).

                Anyway thanks a lot for correcting those bugs, I’m sure that would help somebody with the same issue!

                S M 2 Replies Last reply Sep 8, 2017, 7:42 PM Reply Quote 0
                • S Offline
                  strawberry 3.141 Project Sponsor Module Developer @ArkantosArk
                  last edited by Sep 8, 2017, 7:42 PM

                  @ArkantosArk Yes, midori doesn’t support ES6 and the module makes use of it. Try to run it and access it via a browser on another machine for testing purposes it should probably work.

                  Please create a github issue if you need help, so I can keep track

                  1 Reply Last reply Reply Quote 0
                  • M Offline
                    matteodanelli @ArkantosArk
                    last edited by Sep 9, 2017, 9:52 AM

                    @ArkantosArk As @strawberry-3-141 mentioned, I use ES6 in the module and so some old browsers aren’t working. Midori uses an old version of the web engine, but I know that it’s the best browser on the RPi1.

                    However, I tried to replace in my module a function which creates a problem. I am not sure to have solved totally the problem because I cannot test on Midori.
                    I’ve updated the module so you can test it now, hoping that it’s working, or at least it shows less problems :)

                    Let me know!

                    A 1 Reply Last reply Sep 11, 2017, 7:35 PM Reply Quote 0
                    • A Offline
                      ArkantosArk @matteodanelli
                      last edited by Sep 11, 2017, 7:35 PM

                      @matteodanelli Now it’s working! thanks a lot for this I feel really privileged!. Thanks for taking the effort to update the module just for this.

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 7
                      • 8
                      • 4 / 8
                      4 / 8
                      • First post
                        33/77
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy