new update/upgrade script, ready for testing

evroom

Sam,

for some reason your testlang.sh script, using alias, is still responding in German, whereas the plain command responses in English:

pi@raspberrypi:~/MagicMirror $ curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash
Auf Branch master
Ihr Branch ist auf demselben Stand wie 'origin/master'.
:
:

pi@raspberrypi:~/MagicMirror $ LC_ALL=C git status
On branch master
Your branch is up to date with 'origin/master'.
:
:

pi@raspberrypi:~/MagicMirror $ git status
Auf Branch master
Ihr Branch ist auf demselben Stand wie 'origin/master'.
:
:

Also interesting; using sh iso bash:

pi@raspberrypi:~/MagicMirror $ curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | sh
On branch master
Your branch is up to date with 'origin/master'.

EDIT - recommendations / friendly advice:

1/ Use #!/bin/bash in your script, not ~/bin/bash
2/ Do not alias the git command, just plain LC_ALL=C git status

I am on 2.10.0, but can try your testlang.sh script when needed.
Will keep the language settings on German for a while.

sdetweil

@evroom thanks… I have multiple commands to issue, and wanted to use alias for it…

thanks for the catch on #~…

can u try the test script again?
u can also look at the alias list , to make sure the one for git is set

alias

spitzlbergerj

@evroom said in new update/upgrade script, ready for testing:

locale -a

the output is:

C
C.UTF-8
de_DE.utf8
POSIX

spitzlbergerj

@sdetweil Hi, I run the script just now again. The output is the same I guess:

curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash
Auf Branch master
Ihr Branch ist zu 'origin/master' um 117 Commits hinterher, und kann vorgespult werden.
  (benutzen Sie "git pull", um Ihren lokalen Branch zu aktualisieren)
Unversionierte Dateien:
  (benutzen Sie "git add <Datei>...", um die Änderungen zum Commit vorzumerken)

        core
        installers/dumpactivemodules.js

nichts zum Commit vorgemerkt, aber es gibt unversionierte Dateien (benutzen Sie "git add" zum Versionieren)

sdetweil

@spitzlbergerj don’t yah love it… what is supposed to work, doesn’t…

arg

sop I changed test script to do it your way… try it out

spitzlbergerj

@sdetweil Sorry if I misunderstood something. Should I have corrected something on my own?

OK, I started the script again. Now the output is as follows:

curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash
On branch master
Your branch is behind 'origin/master' by 117 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        core
        installers/dumpactivemodules.js

nothing added to commit but untracked files present (use "git add" to track)

And the update script returns the following output:

bash -c  "$(curl -sL https://raw.githubusercontent.com/sdetweil/MagicMirror_scripts/master/upgrade-script.sh)"
the log will be /home/pi/MagicMirror/installers/upgrade.log
No LSB modules are available.
doing test run = true
update log will be in /home/pi/MagicMirror/installers/upgrade.log

saving custom.css
upgrading from version 2.9.0 to 2.10.0
fetching latest revisions
processing dependency changes for active modules with package.json files

processing for module MMM-Remote-Control please wait
----------------------------------
skipped processing for MMM-Remote-Control, doing test run
processing complete for module MMM-Remote-Control

processing for module MMM-NetworkScanner please wait
----------------------------------
skipped processing for MMM-NetworkScanner, doing test run
processing complete for module MMM-NetworkScanner

processing for module MMM-DWD-WarnWeather please wait
----------------------------------
skipped processing for MMM-DWD-WarnWeather, doing test run
processing complete for module MMM-DWD-WarnWeather

processing for module MMM-SystemStats please wait
----------------------------------
skipped processing for MMM-SystemStats, doing test run
processing complete for module MMM-SystemStats

restoring custom.css

So it all worked out now, right?

Thanks for your help @sdetweil and @evroom

sdetweil

@spitzlbergerj said in new update/upgrade script, ready for testing:

upgrading from version 2.9.0 to 2.10.0

all looks good… thank you so much for your time and patience…

but… the upgrader says u are still on 2.9… maybe a different folder? (as u said u were on 2.10 already)

spitzlbergerj

This post is deleted!

sdetweil

@spitzlbergerj no attachment… send via mail… same ID as here on gmail

evroom

@sdetweil said in new update/upgrade script, ready for testing:

I changed test script to do it your way… try it out

pi@raspberrypi:~/MagicMirror $ curl -sL https://www.dropbox.com/s/80fevh39jme3iig/testlang.sh?dl=0 | bash
On branch master
Your branch is up to date with 'origin/master'.

Sam. I think the issue is, that the command is git status and you alias LC_ALL=C git to the name git, not the command git.
You cannot use the alias as a replacement for a part of your command, but I might be wrong.

I think the only solution is to check for language en_US and then for every git command either use plain git or else by using LC_ALL=C.

Or just use LC_ALL=C for every git call.

sdetweil

@evroom

name git, not the command git

i don’t understand this…

its been working fine for quite a few months, handling LC_ALL and LANGUAGE, just hs system has LANG too…

anyhow, alias is supposed to work on ‘commands’ issued, and replace the started command with the replacement string (once)

this is how the git doc suggested dealing with this issue and stackexchange posts over quite some time echoed it…

I changes to the ‘LC_ALL=C git’ approach anyhow

I don’t even check now, just do it… on english system, it doesn’t hurt

spitzlbergerj

no, I didn’t say I was on 2.10.

i have now run the script in apply mode. The output is very long and apparently it was not updated, right?

Link Text

Sorry, I’ve always done the update via git. Now I am confused …

sdetweil

@spitzlbergerj yes, please erase this file

~/MagicMirror/installers/dumpactivemodules.js

it was copied early by the official updater in error

evroom

@sdetweil

It is always difficult creating something and having it run flawlessly on many different systems with their many different settings, some exotic :-)

One more thing I stumbled upon when googling:

shopt -s expand_aliases

Add this before the alias command, or just at the top of your script.
Seems to work.

spitzlbergerj

@sdetweil
OK, now I have another problem :disappointed_face: . The upgrade script ran and I think it upgraded some stuff.

At some point, I must have gotten my permissions mixed up. There were a number of directories that were root:root. Here there was Permission denied.

I have now corrected the owners. But now the upgrade script doesn’t run anymore, because it assumes that I am already on 2.10.

Can I force another upgrade?

sdetweil

@spitzlbergerj yes, change ‘apply’ to ‘force’

sdetweil

@evroom I decided to forget about alias altogether…

evroom

@sdetweil said in new update/upgrade script, ready for testing:

I decided to forget about alias altogether…

Of course, your script, your call.
Just keep it somewhere in the back of your head, should you stumble over it again in any way or form.
As I minimum I learned something new, including using alias in a script at all.

Thanks for the scripts and the help you provide to all users with fresh install and / or upgrade issues, including myself.

sdetweil

@evroom thanks for your help… I had learned about the shell options to expand aliases about 10 yrs ago, and forgot… my systems all run with it on.

spitzlbergerj

@sdetweil
now it worked, my MagicMirror is on the current version :smiling_face_with_open_mouth_smiling_eyes: :thumbs_up: .

Many, many thanks for your patient help. It was a somewhat more difficult birth. But the end is good and so everything

I have a lot of respect for you, who created such a complex script and patiently provides support. Thank you very much!

One last question:
During the update there was another message:

npm WARN deprecated @types/vfile-message@2.0.0: This is a stub types definition. vfile-message provides its own type definitions, so you do not need this installed.

Is there anything else I should do?