MMM-NHL - NHL Score and Schedule module

j.e.f.f

I’ve been playing with this module during the playoffs, and I’ve found a few bugs that were causing this module to fail. I’ve fixed them in my local copy, but I don’t know how to go about getting them incorporated into the official download.

I’ve also changed the visual formatting for myself, and am willing to share if anyone wants it:
0_1492924456676_Screen Shot 2017-04-23 at 1.13.59 AM.png

Thanks for this wonderful module! Been fun watching the playoffs and tweaking this at the same time. I’d like to make similar ones for other sports – NBA, MLB, CFL – and I’m willing to provide front-end formatting if someone would take care of coding the data fetch.

Jeff

reflektor

@j.e.f.f I’d love to get a copy of your fixes and visual tweaks! Maybe upload the .zip somewhere and share?

j.e.f.f

@reflektor Sure. I’ve done more or less the same for MLB and NBA too. Basically in each case it is a rewrite of the getDom() portion of the module, along with styles to support the new markup. Also I changed the logos to use SVG files so they would scale to whatever size I needed. Spent quite a bit of time playing around with proportions before I settled on this. PM me and I can send you the files.

ooom416354

@ooom416354 said in MMM-NHL - NHL Score and Schedule module:

I have a small issue with the module, wondering if it’s something I screwed up. Basically it will refresh with the realtime scores for any games listed on the mirror. But after the game ends it will not add on any new scores and remove the old scores as the days move forward. for example, I have focus on the NY Islanders and they played Saturday, Sunday and Tuesday. They are scheduled to play tonight as well. On my mirror right now are the 3 previous games but not the next 3. If I reload the entire page it will update with tonights game and any future ones. Is there something I need to do to get it to update automatically without having to refresh the whole mirror?

Hi, I am having this issue again where if I refresh the mirror myself, it will update otherwise it stays static. The scores change but it doesnt retrieve the future games. @Trentent is there anything I can do ?

Sasouter

@j-e-f-f Hi. Could I get a copy of your updated NHL files?
Thanks
@sasouter

cowboysdude

What’s really funny about the NHL as opposed to all the other sports is that modules fail for some reason …mine did also but I haven’t had time to fix it…

j.e.f.f

@sasouter said in MMM-NHL - NHL Score and Schedule module:

@j-e-f-f Hi. Could I get a copy of your updated NHL files?
Thanks
@sasouter

I don’t have them anymore. I’ve made my own sports module called MMM-MyScoreboard that looks like what I’ve done here.

stephenmelody

I don’t know if this should be on this module thread or the core system thread, I’ve just updated to the latest version and now this module pulses on the screen every second as it polls the nhl api. It didn’t do this prior to me upgrading yesterday, it would just be static and the score would update.

Is this something that is easily fixed? None of my other modules seem to have this issue but non are polling data so regularly.

Any clues?! Thanks!!

A Former User

Dear all,

is anybody still using this module? After installing on a blank MagicMirror installation (Pi4, installation script from SDetweil, nothing else) it comes up with error:

[ERROR] (node:45285) UnhandledPromiseRejectionWarning: Error [ERR_REQUIRE_ESM]: require() of ES Module /home/nico/node_modules/node-fetch/src/index.js from /home/nico/MagicMirror/modules/MMM-NHL/node_helper.js not supported.
Instead change the require of index.js in /home/nico/MagicMirror/modules/MMM-NHL/node_helper.js to a dynamic import() which is available in all CommonJS modules.
    at c._load (node:electron/js2c/node_init:2:13672)
    at Object.<anonymous> (/home/nico/MagicMirror/modules/MMM-NHL/node_helper.js:16:15)
    at c._load (node:electron/js2c/node_init:2:13672)
    at loadModule (/home/nico/MagicMirror/js/app.js:183:19)
    at loadModules (/home/nico/MagicMirror/js/app.js:213:10)
    at async App.start (/home/nico/MagicMirror/js/app.js:261:3)
(Use `electron --trace-warnings ...` to show where the warning was created)
[2024-06-01 11:13:55.699] [ERROR] (node:45285) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

It’s a nice little module with great benefits for NHL fans, Since it’s been a while, that fewieden has developed it, it might be out of date. It’s a pity to see that it no longer works.
Any ideas to bring it back to life?