MMM-soccer v2

matze86

here is the output from the console

MMM-soccer: "received a Socket Notification: MATCHES"
MMM-soccer.js:432 MMM-soccer: "Calculating Team Display Boundaries"
MMM-soccer.js:432 MMM-soccer: "Focus on Team"
MMM-soccer.js:432 MMM-soccer: "Finding focus team for table..."
MMM-soccer.js:432 MMM-soccer: "Focus Team found: FC Bayern München"
MMM-soccer.js:432 MMM-soccer: "No Focus Team found! Please check your entry!"
ReferenceError: numberOfNextMatches is not defined
    at Class.prepareMatches (MMM-soccer.js:232)
    at Class.getTemplateData (MMM-soccer.js:182)
    at module.js:89
    at new Promise (<anonymous>)
    at Class.getDom (module.js:86)
    at main.js:114
    at new Promise (<anonymous>)
    at updateDom (main.js:113)
    at Object.updateDom (main.js:551)
    at Class.updateDom (module.js:364)

Why did it say, that no focus team has found? It is highlighted in “league mode”
Furthermore i did not edit the MMM-soccer.js. so i don’t have any idea, why numberOfNextMatches is not defined

matze86

i saw, that the focus for table was not found. thats correct. it is only highlighted in the current matchday…

lavolp3

@matze86 ok I’ll check that error.

lavolp3

@matze86 OK i pushed a fix.
Please do a git pull and let me know if it works better now.

matze86

@lavolp3

It worked! Very nice! Thx a lot👍🏻

Now i‘m „fighting“ with the css and the alignment in the table. See the picture for more Details

lavolp3

@matze86 yeah another issue i have just now realized. Give me a bit of time.

lavolp3

@lavolp3 should be fixed now. Only one css line
Again, please do a git pull

matze86

@lavolp3
I fixed it by my own

I can send you the css of you want

Is ist possible to delete the last games of my team?

I only found a Solution to reduce it from 3 to 2 , by editing line 247 (changing the number in bracktes), but each other Number than 3 will only reduce it to 2 Games

lavolp3

@matze86 Change line 249 in MMM-soccer.js from

for (var i = index - 1; i < filteredMatches.length; i++) {
                    nextMatches.push(filteredMatches[i]);
                }

to


for (var i = index; i < filteredMatches.length; i++) {
                    nextMatches.push(filteredMatches[i]);
                }

(Remove the “- 1”)

matze86

@lavolp3

i changed it to “+ 1”, because with with i = index it will still display the last game. Or when will the module update the game list? i think on the next matchday?

lavolp3

@matze86
Hm. The module has a range of future and recent games.
Then it searches for the index of the first game after the current date.
THen takes that value as index, so index should be the next game, index-1 the last and index+1 the one after the next.

Does your workaround actually work?
Then I’m thinking wrong.

matze86

@lavolp3

On monday it still displayed the last Game with „Index“
Today it works as you described. So this is the best Solution (for me)
next

Other Topic:
league

When will the matchday in „league“ change to the next?

Is it possible to add More columns to the table like this? Or to add up/down arrows? Or to add further Information like CL-Position/EL-Position and so on?

lavolp3

@matze86 said in MMM-soccer v2:

Is it possible to add More columns to the table like this? Or to add up/down arrows? Or to add further Information like CL-Position/EL-Position and so on?

I added played games as a column just today . Up and down arrows are a good idea but I need to check if the API gives the most recent table. I don’t think so.
Good idea!
They positions (relegation, qualifications) is most probably not possible.
I’ll check.

matze86

@lavolp3

Great! I‘ll Update the Module soon

Maybe with a different colour for the Position?

lavolp3

@matze86 said in MMM-soccer v2:

@lavolp3

Great! I‘ll Update the Module soon

Maybe with a different colour for the Position?

So I checked the API output. Unfortunately we don’t have a reference for the recent table position.


"table": [{
	"position": 1,
	"team": {
		"id": 5,
		"name": "FC Bayern München",
		"crestUrl": "https://crests.football-data.org/5.svg"
	},
	"playedGames": 26,
	"form": "W,W,W,W,L",
	"won": 19,
	"draw": 4,
	"lost": 3,
	"points": 61,
	"goalsFor": 78,
	"goalsAgainst": 35,
	"goalDifference": 43
  },
  ...

We would have to call the API again for the last matchday’s table, which consumes API calls.
I’m not sure if I want that.
I still very much like the idea however.

Also, you can see there’s no reference to relegation or qualification ranks

matze86

@lavolp3

Allright… Too Bad…

Here you can see my momentary Soccer Dashboard. I copied your module three times with different configs.
But i‘m Not statisfied with the Symbols of fontawesome. Are there other Styles possible?
I think the api also does Not give the Information about the time of Match?

lavolp3

@matze86 said in MMM-soccer v2:

I think the api also does Not give the Information about the time of Match?

It does.
Usually APIs work with timestamps or date strings including date and time.
My module is set to only show the time at the day of match. It does not show date AND time due to limited space.

if (match.status == "SCHEDULED" || match.status == "POSTPONED") {
                    match.state = (moment(match.utcDate).diff(moment(), 'days') > 7) ? moment(match.utcDate).format("D.MM.") : (moment(match.utcDate).startOf('day') > moment()) ? moment(match.utcDate).format("dd") : moment(match.utcDate).format("LT");

matze86

@lavolp3

thx. now i’ll come closer to a perfect overview :thumbs_up:

Egnos

Hi @lavolp3 I downloaded your module from here:
https://bytemeta.vip/repo/lavolp3/MMM-soccer

But for some reason the results of the Champions League do not show the logos of the teams and also the results seem to me formatted badly.
Am I doing something wrong?
Follow a screenshot:

Here is the config.js:

{
    module: 'MMM-soccer',
    position: 'top_right',
    config: {
        api_key: '2c709c5e9c9a491a88b810c43ae00f0e',
        show: ['SA'],
        colored: true,
        logos: true,
        updateInterval: 60,
        showTables: false,
        focus_on: {
			'SA': 'FC Juventus'
					},
        max_teams: 5,
        matchType: 'league'
			}
		},
		
		{
    module: 'MMM-soccer',
    position: 'top_left',
    config: {
        api_key: '2c709c5e9c9a491a88b810c43ae00f0e',
        show: ['CL'],
        logos: true,
        colored: true,
        updateInterval: 60,
        focus_on: {
			'CL': 'FC Juventus'
					},
        max_teams: 5,
        matchType: 'league'
			}
		},

Thanks.

thymon

Hello,

the same here with FL1 league.