Has anyone got MMM-Remote-Control working on MM 2.11 ?

sdetweil

@RoadRunnr1469 said in Has anyone got MMM-Remote-Control working on MM 2.11 ?:

I can’t seem to get the upload screenshot to work, but yes I see all my modules.

posting images is broken

https://github.com/MichMich/MagicMirror/issues/1969

karsten13

may you can post the content of your ./js/socketclient.js?
So please go into the magicmirror folder and execute cat ./js/socketclient.js and post the output here. Thanks.

RoadRunnr1469

@karsten13

var MMSocket = function(moduleName) {
	var self = this;

	if (typeof moduleName !== "string") {
		throw new Error("Please set the module name for the MMSocket.");
	}

	self.moduleName = moduleName;

	// Private Methods
	self.socket = io("/" + self.moduleName);
	var notificationCallback = function() {};

	var onevent = self.socket.onevent;
	self.socket.onevent = function(packet) {
		var args = packet.data || [];
		onevent.call(this, packet);    // original call
		packet.data = ["*"].concat(args);
		onevent.call(this, packet);      // additional call to catch-all
	};

	// register catch all.
	self.socket.on("*", function(notification, payload) {
		if (notification !== "*") {
			notificationCallback(notification, payload);
		}
	});

	// Public Methods
	this.setNotificationCallback = function(callback) {
		notificationCallback = callback;
	};

	this.sendNotification = function(notification, payload) {
		if (typeof payload === "undefined") {
			payload = {};
		}
		self.socket.emit(notification, payload);
	};
};

karsten13

@RoadRunnr1469

didn’t ask you, because I know your socketclient.js, you applied my patch …

RoadRunnr1469

@karsten13 actually no I didn’t. I had backed up my entire MagicMirror folder and all sub folders before upgrading. I saw another post where they said they changed the socketclient back to before upgrade. so I did the same thing. after making a backup of the new socketclient.js file.

Stoffbeuteluwe

@RoadRunnr1469 so…After restart MM …Remote Control is not working anymore :worried_face:

sdetweil

@Stoffbeuteluwe put his fix on the js/socketclient.js

snikolaidis

what if cat ./js/socketclient.js says the file doesn’t exist? Would it be located somewhere else for the MagicMirrorOS?

karsten13

you are using this setup?

snikolaidis

@karsten13 yes I am