Has anyone got MMM-Remote-Control working on MM 2.11 ?

[RoadRunnr1469]

I updated to MM 2.11and the MMM-Remote-Control module quit working. I have tried checking settings, totally removing the module and reinstalling. I have not been successful in getting it to work.

[karsten13]

see https://github.com/Jopyth/MMM-Remote-Control/issues/185

[Stoffbeuteluwe]

@RoadRunnr1469 and @karsten13

I have updated my MM with git pull & npm install …than I had the same problem.
Today I tried Sam‘s Upgrade Script and now everything is working perfect.

[RoadRunnr1469]

I had a copy of the old file socketclient.js located in MagicMirror/js folder. once I replaced the new new file with the backup it is working.
Here is the Key line that needs fixed.

replace

// Private Methods
self.socket = io("/" + self.moduleName, {
	path: window.location.pathname + "socket.io"
});

with

// Private Methods
    self.socket = io("/" + self.moduleName);

[karsten13]

@Stoffbeuteluwe

so your are running MM v2.11.0 with MMM-RemoteControl and all your Menu Items work?

E.g. if I open 192.168.xxx.yyy:8080/remote.html#main-menu in the browser and click on Edit config.js the popup opening only contains 3 lines with undefined.

[RoadRunnr1469]

@karsten13 yes mine appears to be working, but I don’t edit my config there, I edit via SSH.

I can’t seem to get the upload screenshot to work, but yes I see all my modules.

[Stoffbeuteluwe]

@karsten13 for me it works after upgrade with sams script

[sdetweil]

@RoadRunnr1469 said in Has anyone got MMM-Remote-Control working on MM 2.11 ?:

I can’t seem to get the upload screenshot to work, but yes I see all my modules.

posting images is broken

https://github.com/MichMich/MagicMirror/issues/1969

[karsten13]

@Stoffbeuteluwe

may you can post the content of your ./js/socketclient.js?
So please go into the magicmirror folder and execute cat ./js/socketclient.js and post the output here. Thanks.

[RoadRunnr1469]

@karsten13

var MMSocket = function(moduleName) {
	var self = this;

	if (typeof moduleName !== "string") {
		throw new Error("Please set the module name for the MMSocket.");
	}

	self.moduleName = moduleName;

	// Private Methods
	self.socket = io("/" + self.moduleName);
	var notificationCallback = function() {};

	var onevent = self.socket.onevent;
	self.socket.onevent = function(packet) {
		var args = packet.data || [];
		onevent.call(this, packet);    // original call
		packet.data = ["*"].concat(args);
		onevent.call(this, packet);      // additional call to catch-all
	};

	// register catch all.
	self.socket.on("*", function(notification, payload) {
		if (notification !== "*") {
			notificationCallback(notification, payload);
		}
	});

	// Public Methods
	this.setNotificationCallback = function(callback) {
		notificationCallback = callback;
	};

	this.sendNotification = function(notification, payload) {
		if (typeof payload === "undefined") {
			payload = {};
		}
		self.socket.emit(notification, payload);
	};
};

[karsten13]

@RoadRunnr1469

didn’t ask you, because I know your socketclient.js, you applied my patch …

[RoadRunnr1469]

@karsten13 actually no I didn’t. I had backed up my entire MagicMirror folder and all sub folders before upgrading. I saw another post where they said they changed the socketclient back to before upgrade. so I did the same thing. after making a backup of the new socketclient.js file.

[Stoffbeuteluwe]

@RoadRunnr1469 so…After restart MM …Remote Control is not working anymore :worried_face:

[sdetweil]

@Stoffbeuteluwe put his fix on the js/socketclient.js

[snikolaidis]

what if cat ./js/socketclient.js says the file doesn’t exist? Would it be located somewhere else for the MagicMirrorOS?

[karsten13]

you are using this setup?

[snikolaidis]

@karsten13 yes I am

[karsten13]

then you will not find the socketclient.js on your pi because this file is in the used docker image.
2 possibilities:

• you have to mount a fixed version of this file into the running container with a volume mount
• you can use the develop version of the docker image which contains the current develop branch of mm where this is already fixed (this is the current base of the upcoming MM v2.12)

Don’t know how experienced you are in docker, 2. option is easier to explain.

[snikolaidis]

@karsten13 I am a complete novice to it, but I will figure out a way, thank you so much for pointing me in the correct path!

[karsten13]

then goto ~/magicmirror/run and edit the docker-compose.yml with an editor (e.g. nano or vi).

In this file replace karsten13/magicmirror:latest with karsten13/magicmirror:develop, save the file.

You are still in ~/magicmirror/run, then run docker-compose up -d.

It will take a while because this will pull a new docker image.

After the app is up again, the problem should be fixed.