remoteFile in compliments module

Mykle1

compliments.js_original

So, you did change something in the module file? That is not recommended and it makes it very difficult for me or anyone else to troubleshoot for you

Lahim

I tried to change

remoteFile: null,

for remoteFile: ‘compliments.json’ previously but, as you know, did not help.
Now I came back to the oryginal file, saved your compliments as json file in Notepad++ as you wrote, and…
IT IS WORKING!!!

Thank you so much!!!
F…ck, so many time I spent tring different solutions and finaly it works.
One more time thank you for attention and help!
The module - great job!!

Lahim

Ok, I found where was the problem and where is the problem now.
Because I am using Pi0 with Midori, with oryginal file the compliments were not show on the mirror but I was able to see them thru LAN.
So I found the solution to change:

if (this.config.remoteFile != null) {
                this.complimentFile((response) => {
                        this.config.compliments = JSON.parse(response);
                });
        }

to:

         if (this.config.remoteFile != null) {
                this.complimentFile(
                        function(response){
                                this.config.compliments = JSON.parse(response);
                });
        }

and yes, that make my compliments shown on mirror but in same time the text is only from compliments.js file.
So now, to see the compliments I have to copy own text to .js file :(

That is the problem.

Mykle1

@Lahim said in remoteFile in compliments module:

IT IS WORKING!!!
Thank you so much!!!

Fantastic! You’re welcome. :-)

Lahim

Will you be able to find the solution to the problem I described above?

strawberry 3.141

@Lahim because you changed the context by removing the arrow function, to preserve the context you have to do something like:

 if (this.config.remoteFile != null) {
  var self = this;
  this.complimentFile(function(response){
    self.config.compliments = JSON.parse(response);
  });
}

Lahim

I found it in the meantime but now I tested it - yes, it works!!!
Thank you!

zeal

has anyone tried to get the compliments in an file on a external Server?

Mykle1

@zeal

I have not. By default, the compliments module looks for the compliments.json file in the compliments module folder. I suppose you could try using the path to the file on your server in your config entry

remoteFile: "PATH_TO_FILE_ON_SERVER/comliments.json",

Dunno if that will work though.