MagicMirror v2.1.0 Update error

Steff

This post is deleted!

schlachtkreuzer6

@yawns so how do i change the comments if i should´t change the comments.js ? ^^

yawns

@schlachtkreuzer6 said in MagicMirror v2.1.0 Update error:

@yawns so how do i change the comments if i should´t change the comments.js ? ^^

I guess you are talking about compliments.js ?
The readme clearly states how to add own compliments: https://github.com/MichMich/MagicMirror/blob/master/modules/default/compliments/README.md

schlachtkreuzer6

@yawns oh sorry i mean the compliments… i don´t know why i wrote comments (maybe i need more coffee!)

but if i want the default compliments to be in german, what do i need to change? That the git pull is working?

yawns

@schlachtkreuzer6
The same approach. Add whatever you want to add, but do not modify the JavaScript module files.
Create a compliments file or add them to your config file.

Steff

@schlachtkreuzer6
After your question I understood what I personally had done wrong, so I lost my German compliments, still have to confess this to my 8 year old boy who wrote them. Please find here an example with German text how you could modify your local config.js to show German comments:

            {
                    module: 'compliments',
                    position: 'lower_third',

                    config:
                    {
                    compliments:
                       {
                       "morning" : [
                            "Du siehst aber gut aus heute !",
                            "Gut geschlafen ?",
                            "Moin, Moin...."
                            ],
                        "afternoon" : [
                            "Ab Fussball spielen !",
                            "Lass uns auf den Abend vorbereiten....",
                            "Musik hören ?"
                            ],
                        "evening" : [
                            "Einen Cocktail ?",
                            "Wow, Du bist aber heiss heute...",
                            "Wollen wir heute abend weggehen ?"
                            ]
                       }
                    }
            },

bhepler

@Steff Remove the " from around the array names (morning, afternoon, evening).

compliments:
             {
             morning : [
                  "Du siehst aber gut aus heute !",
                  "Gut geschlafen ?",
                  "Moin, Moin...."
                   ],
              afternoon : [
                 "Ab Fussball spielen !",
                 "Lass uns auf den Abend vorbereiten....",
                  "Musik hören ?"
                  ],
              evening : [
                  "Einen Cocktail ?",
                  "Wow, Du bist aber heiss heute...",
                  "Wollen wir heute abend weggehen ?"
                  ]
             }
          }

Steff

@bhepler
Thanks for your hint.
I know the doc does not show them. However I understood the documentation that I will need them for an external file. So I wanted to be prepared for the move to an external file. I tested it with them inside the config.js file and it worked. Do you see any specific reason to remove them ?

Steff

I did try to configure an external compliments.json file, however it seems that it is not interpreted, since I do get again the default compliments.
The file is located within the config directory.
My configuration:

{ module: 'compliments', position: 'lower_third', config: { remoteFile: 'compliments.json' } },

Do you have a hint what might be wrong ?

bhepler

@Steff Due to my own incompetence when dealing with javascript, the external file needs to have quotes around the array names. If you are expanding the arrays within the config.js file, then you must remove the quotes from around the names.
So this would work in the config.js file:

evening : [
        "Einen Cocktail ?",
        "Wow, Du bist aber heiss heute...",
        "Wollen wir heute abend weggehen ?"
        ]

and this should work in the external compliments file:

"evening" : [
        "Einen Cocktail ?",
        "Wow, Du bist aber heiss heute...",
        "Wollen wir heute abend weggehen ?"
         ]

It’s a bug. But I’m a Java programmer, not a Javascript programmer. I don’t know how to fix it.