Transit module stopped working

[sdetweil]

@nipper2000h yes, probably. I would post an issue to the module GitHub page to inform them

[nipper2000h]

@sdetweil Thanks again.

[Elaniobro]

@sdetweil what makes you think the API changed? ( I am the author, and am looking into it now)

[sdetweil]

@Elaniobro I posted a couple messages back the error info. node_helper line 106 called something which threw an error

2020-06-30 09:41:59.974] [ERROR]  (node:882) UnhandledPromiseRejectionWarning: Error: Error: Illegal group end indicator for Message .transit_realtime.FeedMessage: 7 (not a group)
0|mm       |     at /home/pi/MagicMirror/modules/MMM-nyc-transit/node_helper.js:106:15

[elliob]

@sdetweil how did you get to error message? What’s the CLI?

[sdetweil]

@elliob it was in the pm2 log in the 1st post of this topic

[nipper2000h]

@elliob I’m using pm2 to start MM so from the root directory:

pm2 logs mm

[sdetweil]

@nipper2000h the logs are stored in the users .pm2 folder. doesn’t matter where I issue the pm2 commands

[Elaniobro]

The module is getting the data, but its not updating with the this.updateDom method. I am not sure if this was deprecated or not. Looking into it.

[sdetweil]

@Elaniobro how does it use this.updateDom()

[Elaniobro]

@sdetweil Its called in the socketNotificationReceived() here:
https://github.com/Elaniobro/MMM-nyc-transit/blob/master/MMM-nyc-transit.js#L358-L360

[sdetweil]

@Elaniobro where is self set.? and fadeSpeed?

[Elaniobro]

@sdetweil They aren’t, they can be removed. Issue I am seeing is the payload is not populated indo the getDom()

I am setting this.result = payload which on intitial load/start of the module is undefined, which is expected, since the API promise has not been fulfilled. Later on, the socketNotificationReceived() recieves a payload which is set to this.result but in the getDom() var data = this.result is never updated.

I am unsure of where/what caused this breakdown, as last time I touched the code was Apr 30. This is leading me to believe something changed in Core, but I am unaware of what that might be.

[sdetweil]

@Elaniobro are u debugging w the developers window?
you can walk thru the code as it executes
ctrl-shift-i and select the sources tab, use the tree on the left to find your module, and it’s source

then click the left edge of a line of code u want to examine, and a stop will be added.

usually a problem like this is because the ‘this.’ pointer doesn’t point where u think it does.

sorry, I am in hospital for a few more days and cannot debug from here

[Elaniobro]

@sdetweil Thank you for your feedback. I am/was already debugging in the manner you mentioned. I was able to resolve the bug(s), but now I am still not seeing any data. My best guess is somewhere along the fetch of the data something changed or broke. The application is returning data, but the response is empty.

payload = [{ downTown: [] }, { upTown: [] }]

For some reason, just not getting any data :/

I am still digging in.

[sdetweil]

@Elaniobro boooo. always something! let me know if I can help

[sdetweil]

@Elaniobro probably another ‘this’ pointer issue

[Elaniobro]

@sdetweil Welcome to assist, you can find the repo here: https://github.com/Elaniobro/MMM-nyc-transit

I do have it cleaned up a bit locally, but I am thinking my API key is no longer valid and or something changed upstream that I am not aware of. The mirror is doing what it should and returning results array, but the array is empty.

[sdetweil]

@Elaniobro using the default config, i also see the lack of info

    client.departures(stations)
      .then((responses) => {
        var upTown = []
        var downTown = []

        console.log("api results="+JSON.stringify(responses))

actual data

 api results=[{"complexId":237,"name":"Carroll St","lines":[{"name":"6th Av - Culver","departures":{"S":[],"N":[]}}]},{"complexId":177,"name":"Clinton - Washington Avs","lines":[{"name":"8th Av - Fulton St","departures":{"S":[],"N":[]}}]}]

config

    config: {
      apiKey: '****',   // just granted
      displayType: 'marquee',
      mtaType: 'train',
      stations: [
        {
          stationId: 237,
          walkingTime: 5,
          dir: {
              upTown: false,
              downTown: true
          }
        },
        {
          stationId: 177,
          walkingTime: 5,
          dir: {
            upTown: true,
            downTown: false
          }
        }
      ],

[Elaniobro]

We can close this issue, it was resolved on github. The module itself never broke, it was an upstream service that did. A module that I was using, was using deprecated endpoints. I spoke with the developer and the MTA and we were able to isolate and resolve it.

In addition, not only did the endpoints change but any API keys generated on their old site, datamine.mta.info will no longer work.

You will need to create a new one via api.mta.info moving forward.

Thank you for your assist and feed back.