Default Weather module still not displaying

[sdetweil]

@Jarhead96097

I added a command above to restore the original weather.js from the git repo

[Jarhead96097]

@sdetweil I added “npm audit fix” as there was 1 high severity vulnerability found. It didn’t solve the vulnerability (didn’t try “npm audit fix --force”), and I’m getting the same error.

[Jarhead96097]

@sdetweil Oh, okay. Let me try that updated string of commands…

[sdetweil]

@Jarhead96097 please never do audit… causes more problems than it fixes

[mumblebaj]

@Jarhead96097 Rule of thumb is to never run npm audit fix.

[sdetweil]

@mumblebaj and we have found npm install parms to turn off the warning coming in next release, and already in my scripts.

[mumblebaj]

@sdetweil That’s great

[Jarhead96097]

@sdetweil Good to know…that may be the root cause of all of this. After rebuilding my MM on 2.20.0, I did the npm audit fix. If we can’t get to a resolution in the next few minutes, I’ll chalk this up to a learning experience and do another rebuild.

[OldSunGuy]

May I ask how you are using

classes: "daytime_scheduler"

Are there two instances of

daytime_scheduler

I use

classes: “currentweather”

type: “current”

and

classes: “weatherforcast”

type: “forecast”

to replace the deprecated modules.

[sdetweil]

@Jarhead96097 use my install script

see
https://github.com/sdetweil/MagicMirror_scripts

[Jarhead96097]

@sdetweil “On branch master,” and up to date with origin/master. I also meant to reply earlier that this is on a RPI 4B. Unfortunately, still getting the same error and the weather module is not displaying information.

I appreciate everyone’s time…but I’m going to cut to the chase and rebuild using your install script.

Thanks again for the time, you’re always very helpful, and I appreciate it.

[sdetweil]

@Jarhead96097 ah, one other question, what is the current node level

node --version

[Jarhead96097]

@sdetweil sorry, already using your installation script (but no “npm audit fix” this time around).

[Blackeye]

@sdetweil On my RPi4 it’s 16.16.0, and I’m getting the same problems as Jarhead. After an upgrade there’s now just no reaction to starting mm.

[sdetweil]

@Blackeye can u show the output of the npm start or, if using pm2 , then

pm2 logs --lines=50

how did u do the upgrade?

[sdetweil]

@Blackeye also, can u show me the contents of line 159 from

~/MagicMirror/modules/default/weather/weather.js

[Jarhead96097]

@OldSunGuy I use the MMM-ModuleScheduler 3rd party module to control when my MM turns off everything except the clock and dims the display at night. “daytime_scheduler” is the class I used to turn off those modules at night.

[Jarhead96097]

@sdetweil here is what my weather.js (newly rebuilt, but not yet configured) has on lines 148 to 166:

	// What to do when the weather provider has new information available?
	updateAvailable: function () {
		Log.log("New weather information available.");
		this.updateDom(0);
		this.scheduleUpdate();

		if (this.weatherProvider.currentWeather()) {
			this.sendNotification("CURRENTWEATHER_TYPE", { type: this.weatherProvider.currentWeather().weatherType.replace("-", "_") });
		}

		const notificationPayload = {
			currentWeather: this.weatherProvider?.currentWeatherObject?.simpleClone() ?? null,
			forecastArray: this.weatherProvider?.weatherForecastArray?.map((ar) => ar.simpleClone()) ?? [],
			hourlyArray: this.weatherProvider?.weatherHourlyArray?.map((ar) => ar.simpleClone()) ?? [],
			locationName: this.weatherProvider?.fetchedLocationName,
			providerName: this.weatherProvider.providerName
		};
		this.sendNotification("WEATHER_UPDATED", notificationPayload);
	},

[Jarhead96097]

@sdetweil Sam, thanks for all of your help. I’ve finished rebuilding without running ‘npm audit fix’ and everything is working as it should! I used your installation script and everything worked fine. I also took the opportunity to move things around and try a couple of new 3rd party modules… everything is back to normal!

Thanks again,
Jarhead96097

[sdetweil]

@Jarhead96097 said in Default Weather module still not displaying:

  const notificationPayload = {
  	currentWeather: this.weatherProvider?.currentWeatherObject?.simpleClone() ?? null,

thats line 158 and159.

the only thing i can think of is the ?. (optional chaining) operator…
but its been long supported… and it works on my 16.9.1 node version

see item 2 in the list here
https://www.freecodecamp.org/news/how-the-question-mark-works-in-javascript/