MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Automatic checking of all MagicMirror² modules

    Scheduled Pinned Locked Moved Development
    83 Posts 9 Posters 83.9k Views 10 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S Offline
      sdetweil @KristjanESPERANTO
      last edited by

      @KristjanESPERANTO

      could we separate out the cosmetic issues (MagicMirror vs the one with the superscript 2, as I don’t know how to make that happen in my text editor…) and its useless

      and this is misleading

      MMM-AareGuru by buge
      There is no package.json. We need this file to gather information about the module.
      

      there is no need for a package,json… as this module does all its work inside the modulename.js
      there is no functional requirement as there is no node_helper.js

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      KristjanESPERANTOK 1 Reply Last reply Reply Quote 1
      • S Offline
        sdetweil @KristjanESPERANTO
        last edited by

        @KristjanESPERANTO
        additionally… a module I forked was marked as present and attributed to me, but I never posted it… MMM-Alexa (and I deleted it from your list… and it is NOT present in the master list )

        and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it

        MMM-SleepWake.

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        KristjanESPERANTOK 1 Reply Last reply Reply Quote 1
        • KristjanESPERANTOK Offline
          KristjanESPERANTO Module Developer @sdetweil
          last edited by

          @mumblebaj said in Automatic checking of all MagicMirror² modules:

          Just out of interest, which image does it select as the thumbnail?

          If the script doesn’t find an image with ‘screenshot’ or ‘example’ at the beginning of the name it takes the first it finds .

          The prerequisite for the whole thing is that a free license is specified in the package.json. If there is no package.json and no free license, no image will be searched.

          Stats were great, fixed most of the issues identified in my modules.

          Nice, thank you! I just updated the list and a lot of issues disappeared 👏

          @sdetweil said in Automatic checking of all MagicMirror² modules:

          I don’t know how to make that happen in my text editor

          On my keyboard it’s just +

          and its useless

          I think it’s worth striving to call things by their proper names, so I don’t find the test useless. Feel free to just ignore it :-)

          there is no need for a package,json… as this module does all its work inside the modulename.js there is no functional requirement

          You are right, functionally there is no need for this. However, the file is a good source of information that is interesting for the website - e.g. keywords.

          MMM-Alexa

          Do you know if the original module (https://github.com/sakirtemel/MMM-alexa) still works? Otherwise I should mark it as outdated.

          and one of my modules (the only one I have ever posted) is not present in the master list , and I did not remove it. MMM-SleepWake

          I’ve added it now :-)

          S JalibuJ 2 Replies Last reply Reply Quote 0
          • S Offline
            sdetweil @KristjanESPERANTO
            last edited by sdetweil

            @KristjanESPERANTO I have no info on MMM-Alexa or why i forked it

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            1 Reply Last reply Reply Quote 1
            • KristjanESPERANTOK Offline
              KristjanESPERANTO Module Developer @sdetweil
              last edited by

              @sdetweil said in Automatic checking of all MagicMirror² modules:

              and this is misleading

              There is no package.json. We need this file to gather information about the module.
              

              I added ‘for the website’ at the end of the sentence. I hope that this is clearer.

              Thanks for the feedback :-)

              S mumblebajM 3 Replies Last reply Reply Quote 0
              • S Offline
                sdetweil @KristjanESPERANTO
                last edited by

                @KristjanESPERANTO I have no website.

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                KristjanESPERANTOK 1 Reply Last reply Reply Quote 0
                • KristjanESPERANTOK Offline
                  KristjanESPERANTO Module Developer @sdetweil
                  last edited by

                  @sdetweil Yes, I mean this website: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/. Information from the package.json files is used there.

                  BKeyportB 1 Reply Last reply Reply Quote 0
                  • BKeyportB Offline
                    BKeyport Module Developer @KristjanESPERANTO
                    last edited by

                    @KristjanESPERANTO “This” instead of “The” perhaps?

                    The "E" in "Javascript" stands for "Easy"

                    KristjanESPERANTOK 1 Reply Last reply Reply Quote 1
                    • KristjanESPERANTOK Offline
                      KristjanESPERANTO Module Developer @BKeyport
                      last edited by

                      @BKeyport Good suggestion :-) But what do you think of this:

                      No keywords in 'package.json'. We would use them as tags on the module list website.

                      BKeyportB 1 Reply Last reply Reply Quote 0
                      • BKeyportB Offline
                        BKeyport Module Developer @KristjanESPERANTO
                        last edited by

                        @KristjanESPERANTO Kinda awkward, honestly.

                        The "E" in "Javascript" stands for "Easy"

                        KristjanESPERANTOK 1 Reply Last reply Reply Quote 1
                        • 1
                        • 2
                        • 3
                        • 4
                        • 5
                        • 8
                        • 9
                        • 3 / 9
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy