Automatic checking of all MagicMirror² modules

Jalibu

@KristjanESPERANTO said in Automatic checking of all MagicMirror² modules:

@mumblebaj said in Automatic checking of all MagicMirror² modules:

Just out of interest, which image does it select as the thumbnail?

If the script doesn’t find an image with ‘screenshot’ or ‘example’ at the beginning of the name it takes the first it finds .

Hi @KristjanESPERANTO does it expect the example.png in a specific folder (such as img/ or /) or can it also lookup in docs/?

sdetweil

@KristjanESPERANTO and, this impacts my scripts as i use package.json as the indicator for doing an npm install in the module folder.

KristjanESPERANTO

@Jalibu said in Automatic checking of all MagicMirror² modules:

Hi @KristjanESPERANTO does it expect the example.png in a specific folder (such as img/ or /) or can it also lookup in docs/?

No, you can put it where ever you want :-)

KristjanESPERANTO

@sdetweil said in Automatic checking of all MagicMirror² modules:

@KristjanESPERANTO and, this impacts my scripts as i use package.json as the indicator for doing an npm install in the module folder.

There are some modules that only have devDependencies, so your script already makes unnecessary npm install calls. Can you adjust your trigger and check whether dependencies are set in the package.json?

MZ-BER

Great work @KristjanESPERANTO. Really, really like this. Is there a way to also publish the github stars and # of forks? I also would love if there is a way to “like” a module.

MMRIZE

I suggest you and the community expand package.json to regularise the details of the module. (recommended but optional)
For example;

{
  "name": "mmm-something",
  "version": "1.0.0",
  ...
  "mm" : {
    "communityId" : "johndoe",
    "community" : "MagicMirror forum",
    "screenshot" : "https://somewhere.com/screenshot.png",
    "install" : "https://github.com/johndoe/mmm-something/README.md#installation",
    "update" : "...",
    "email" : "johndoe@somewhere",
    "required: {
      "mm" : "2.25",
      "node" : "18.0"
    },
    "notice" : [
      "This will not work in Windows.",
      "Pre-dependency required. Please readme."
    ]
  }
}

The fields are my imagination. Maybe the community can reach an agreement on rules.

mumblebaj

@KristjanESPERANTO My MMM-SweepClock doesn’t have a package.json either as all work done in the MMM-SweepClock.js file. I can add one for completeness and conformity. I also notice I did not have an image. I usually name my images image-1.png etc. so the main image is generally the first one.

sdetweil

@KristjanESPERANTO oh, and one more thing… my MMM-SleepWake module does not have any UI… so there is no photo…

KristjanESPERANTO

@MZ-BER said in Automatic checking of all MagicMirror² modules:

Great work @KristjanESPERANTO. Really, really like this. Is there a way to also publish the github stars and # of forks? I also would love if there is a way to “like” a module.

Thank you for your appreciation! :-)

karsten13 has already suggested the GitHub API and I have tested it, but if you make requests for 1000 modules you’ll got blocked quickly. I haven’t found another good approach yet.

@MMRIZE said in Automatic checking of all MagicMirror² modules:

I suggest you and the community expand package.json to regularise the details of the module. (recommended but optional)

Storing additional data in the package.json is an interesting idea! But I would like to avoid maintaining data redundantly. So before we tackle this, it would be good to have an overview of the data that is already used for the website and where it is taken from. Plus an additional list of data that is still needed, ideally with ideas on how to collect it. What’s not easy to implement could perhaps be addressed by extending the packge.json.

@mumblebaj said in Automatic checking of all MagicMirror² modules:

My MMM-SweepClock doesn’t have a package.json either as all work done in the MMM-SweepClock.js file. I can add one for completeness and conformity. I also notice I did not have an image. I usually name my images image-1.png etc. so the main image is generally the first one.

At the moment the script has no other source for keywords and the license. And without the license information no image will be taken. If you want an image to be displayed on the website, you would have to specify a free license in the package.json.

@sdetweil said in Automatic checking of all MagicMirror² modules:

my MMM-SleepWake module does not have any UI… so there is no photo…

There is no obligation for an image. But perhaps it would be nice to use an icon that symbolizes motion detection instead of a screenshot. Like this maybe: https://openclipart.org/detail/306403/motion-detection?

karsten13

@KristjanESPERANTO said in Automatic checking of all MagicMirror² modules:

karsten13 has already suggested the GitHub API and I have tested it, but if you make requests for 1000 modules you’ll got blocked quickly. I haven’t found another good approach yet.

2 ideas:

did you try to authenticate with a user before making the api requests? AFAIR we solved a similar problem at work with authentication …
if first idea doesn’t work an ugly solution is to work with e.g. a timer or sleep statement because these infos are not changed very often this could be a long running nightly job

KristjanESPERANTO

@karsten13 said in Automatic checking of all MagicMirror² modules:

did you try to authenticate with a user before making the api requests?

No, I didn’t. Thanks for the hint! I’ll try that! The documentation sounds promising:

Additionally, you can make more requests per hour when you are authenticated.

BKeyport

@KristjanESPERANTO You know, this is turning more and more into a NPM type project.

Perhaps it’s time to work on getting MM into the NPM ecosystem instead?

sdetweil

@BKeyport mm is already there but old

karsten13

@BKeyport

see https://github.com/MichMich/MagicMirror/issues/2876

sdetweil

@karsten13

https://www.npmjs.com/package/magicmirror

BKeyport

I’ve over simplified as I tend to do.

What I was thinking of was more along the lines of how Homebridge is doing things. Full on NPM integrations across the board. GUI installer/maintainer. bonus points for GUI configuration tool on their “plugins” etc. Can still get into the weeds if you want to mess with operations under the hood.

I honestly think it’s time, but I’ve got nowhere near the skill to do it.
MMM-Config on steroids.

The pieces are there - we’re just missing the core.

https://github.com/homebridge/homebridge-raspbian-image/wiki/Getting-Started#step-5-install-and-configure-plugins

Setting the core up would build in a natural module checking system and weed out the unmaintained stuff for new users, because new users won’t want to install stuff that has no GUI settings and/or unmaintained wouldn’t show in the official repository/search anymore.

karsten13

@BKeyport

sounds pretty much like what mmpm does

sdetweil

@karsten13 mmpm doesn’t do config editing
and to do config editing in a reliable way, we need programming standards too.

BKeyport

@sdetweil We already have some standards in place (node_helper.js, naming conventions, package.json, etc) - what’s one more (config-schema.json) for the programmer? Think along the lines of the schema.json file used in MMM-Config.

Programmer creates the GUI settings page, using API into a specific file. It’s up to the core to insert result into the main config file. if GUI file isn’t there, then resort to a web based editor.

https://github.com/homebridge/homebridge/wiki/Verified-Plugins describes the process in homebridge’s case. Provide a reward, and bam - We’ve got easier access to the project, making it more widespread, and it completely eclipses the automatic checking process here.

Reward for the programmer is rather simple. A badge set thusly - everywhere - in the built in plugin manager’s search, on websites, etc.

Example - No GUI settings page file (the dead module):

Example - GUI settings page file (my reworked module with more functionality):

and the resulting config (I believe they use JSON rather than JS):

sdetweil

@BKeyport I believe we use js because you can have comments, json does not support comments