Cannot find module 'node-fetch' error with MMM-SoccerLiveScore

sdetweil

@codac which error? the node-fetch or the lib error?

(@karsten13 we installed electron, my mistake… in docker, doah! )

codac

@sdetweil the node-fetch error

karsten13

if you are using https://github.com/0m4r/MMM-SoccerLiveScore the module contains the missing node-fetch so you should do a git pull in the module folder and try again (which means restart the container)

sdetweil

@karsten13 did they fix the module? I didn’t check

karsten13

@sdetweil

you are right, they “fixed” it in devDependencies instead in dependencies …

then git pull is useless, you have to install the missing library in the module folder as sam already explained above

KristjanESPERANTO

I created a PR to fix this, let’s see when @0m4r accept it.

sdetweil

@KristjanESPERANTO well, npm install would have installed the devDependencies too…

KristjanESPERANTO

@sdetweil Sure. But my PR removes node-fetch, so npm install is no longer necessary for this module.

karsten13

@sdetweil

well, npm install would have installed the devDependencies too…

This sentence clicked in my brain.

I have NODE_ENV=production as default in my images (expect images I use for testing) and with this

npm install will install nothing
npm install node-fetch@2 will install nothing

so @codac please go again in the folder of the module and run NODE_ENV=test npm install node-fetch@2

this should hopefully solve the issue

codac

@karsten13
@codac said in Cannot find module 'node-fetch' error with MMM-SoccerLiveScore:

@sdetweil

root@04492d039b9f:/opt/magic_mirror/modules# cd MMM-SoccerLiveScore              
root@04492d039b9f:/opt/magic_mirror/modules/MMM-SoccerLiveScore# npm install node
-fetch@2                                                                         
                                                                                 
up to date, audited 1 package in 1s                                              
                                                                                 
found 0 vulnerabilities

How would I restart MM of the container?
pm2 is not set up.

DISPLAY=:0 npm restart

…results in

> magicmirror@2.26.0 restart                                                     
> npm stop --if-present && npm start                                             
                                                                                 
                                                                                 
> magicmirror@2.26.0 start                                                       
> DISPLAY="${DISPLAY:=:0}" ./node_modules/.bin/electron js/electron.js           
                                                                                 
sh: 1: ./node_modules/.bin/electron: not found

codac

@karsten13 said in Cannot find module 'node-fetch' error with MMM-SoccerLiveScore:

NODE_ENV=test npm install node-fetch@2

I could see that this time node-fetch got installed (different than before running npm install node-fetch@2 only).
But after restarting the docker container, the same error remained.

karsten13

did the same and it works, so no idea anymore

codac

@karsten13 your are right… somehow the docker didn’t keep the installation after first try.
After installing it a second time and restarting the docker afterwards, the container kept the installation of node-fetch. Its working now.

Thank you guys for your massive support. Big time!
@karsten13, @sdetweil, @KristjanESPERANTO

0m4r

@KristjanESPERANTO thank you!
…and apologies for missing the whole discussion, I have updated my preferences to get e-mails when someone mentions me :)