Read the statement by Michael Teeuw here.
MMM-doomsDay - The countdown module,
-
@Mykle1 My advent module? Even though @broberg hasn’t mentioned it, it seems he based his work on that module.
A feature suggestion from my side: It would feel more like an urgent thing closing in, if it could also show hours/minutes/seconds, too. Maybe use a formatting string for a
moment.js
duration? If I have some time, I might make a PR. -
@Mykle1 Okey, I changed up some variables and I’m not able to test them myself, when you get home, could do a
git pull
on the doomsday module and test it out for me? -
@Jopyth Yes, I stripped out that module for this one, kept the start function and removed the rest since It was a bit over my head at the moment :)
Took me a lot longer than I’m willing to admit just to get the code to compare dates!
Actually thought about the hour/minute countdown as well, but decided to keep it real basic.
I figured you don’t really put that many hours in front of the mirror that it would be that important to see so much detail of the countdown. (And if you look the update interval is set to 5 hours just to keep it in the ballpark) -
@Jopyth said in MMM-doomsDay - The countdown module,:
My advent module?
Yes, that was it. :thumbsup_tone1:
-
@broberg said in MMM-doomsDay - The countdown module,:
when you get home, could do a git update on the doomsday module and test it out for me?
This is what I get when I attempted a git update as you suggested.
pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $ git update
git: ‘update’ is not a git command. See ‘git --help’.Did you mean this?
update-ref
pi@Pi3:~/MagicMirror/modules/MMM-doomsDay $I don’t want to mess anything up so I’ll wait till you advise further, thanks
-
@Mykle1 git pull
-
@Mykle1 sorry my bad mixing up stuff,
git pull
is the command to use in the Mmm-doomsday folder -
A second to slow,@strawberry-3-141 beat me to it :)
-
@broberg said in MMM-doomsDay - The countdown module,:
A second to slow,@strawberry-3-141 beat me to it
A photo finish? Thanks to both of you. :thumbsup_tone1:
{ module: 'MMM-doomsDay', position: 'top_left', // This can be any of the regions, best results in center regions config: { doomsDay: "2017-02-24 24:00:00", // the end day of the countdown, format is YYYY-MM-DD HH:MM:SS, toWhat: 'Open the pool!', // the title of your countdown event present: 'We are gonna rock', // What it should say on doomsDay date singular: `Day Left`, // what it should say when it's only one day left, default is `Day Left` plural: 'Days Left', // what it should say when it's more days left, default is `Days Left` } },
Ok, now the display says, “Open the pool!”, but underneath is says, “0 Days Left”
-
@Mykle1 okey, then my fix didn’t do what I thought. I have restored it to as before, do a new
git pull
to get the last version again.I will have to fix the half-day bug when I get back home :)