Bugsounet and MMM-Pir

rkorell

@sdetweil said in Bugsounet and MMM-Pir:

called minified

:-) never seen this before…
Called minified - for good reasons …

sdetweil

Called minified - for good reasons …

On a production web site with 1000000’s of file loads, minified can reduce response times…

otherwise it is a hiding technique, which can(has) hidden hacker attacks on client systems…(loading files, sending credentials…)
hard to examine code

rkorell

@sdetweil said in Bugsounet and MMM-Pir:

hard to examine code

Yes, I guess this was bugsounet’s intention - irritating beginners :-)

The code has 247 lines so you avoid 247 CR’s - not THAT much more efficient, I think - but on 100eds of 1000nds of files - may be …

Ralf

sdetweil

@rkorell he did not do it for performance

rkorell

@sdetweil I agree :-)

rkorell

@rkorell said in Bugsounet and MMM-Pir:

in the src folder of the repository

@lif , @coernel :
there are several files missing in coernels upload.
I’ve just checked source code in MMM-Pir.js …

      "/modules/MMM-Pir/components/screenDisplayer.js",
      "/modules/MMM-Pir/components/screenTouch.js",
      "/modules/MMM-Pir/node_modules/long-press-event/dist/long-press-event.min.js",
      "/modules/MMM-Pir/node_modules/progressbar.js/dist/progressbar.min.js",
      "/modules/MMM-Pir/components/motion.js",
      "/modules/MMM-Pir/components/motionLib.js"

The complete folder MMM-Pir/node_modules is missing.
The folder MMM-Pir/components/ contains only the python script for PIR communication, none of the above *.js files.

At least the /components/*.js files are present in the components folder of MMM-Pir/src …

But this seems to be a frickling job to get this done.
I guess a complete upload of an original MMM-Pir installation would be the better way.

What do you think?

Regards,
Ralf

sdetweil

@rkorell because they are in node_modules they were dependencies , not part of the actual module…

rkorell

@sdetweil said in Bugsounet and MMM-Pir:

not part of the actual module…

As far as I understood @coernel tried to re-upload bugsounet’s MMM-Pir.
And this modules uses all of these dependencies.
And the original MMM-Pir.js from bugsounet is missing as well in coernel’s re-upload, so it will never work - which is, what @lif has experienced …
So my above suggestion was - if it is intended to have a working copy of bugsounet’s module - to re-investigate the re-uploaded version because there is missing a lot - as mentioned even the core *.js file in the root of the module…

If useful for anybody I’ve created a complete copy of my own working module-directory and uploaded it here for your attention/action.
Please ignore some additional files which I have kept as copies of the original files I had modified.

Hope this is clearer now :-)

Regards,
Ralf

sdetweil

@rkorell yes, i posted a warning early after he left to save what you could, without knowing the details of such work effort

rkorell

@sdetweil Yes, indeed - we had a chat at these time as you might remember.
And here seems to be an opportunity to do “something” against this "bug"sounet thingi …
As @coernel suggested a re-upload could help (a little bit), so I considered this as a really good and nice idea.
But it went wrong - for unknown reasons the given copy is incomplete.

So my suggestion to complete this ta - at least - have a working copy of an elder status …

Ralf

sdetweil

@rkorell yeh, or forget it and move to a current module.
very troubling

lif

Thank you everyone, I’m sorry for opening this can of worms.

I’ve now got a Python script that runs at boot and does the job after destroying my MM installation trying to apply upgrades.

rkorell

@sdetweil :-).
I like it very much because it offers a lot nice and fancy stuff as the others don’t …
(progress bar, dimming, cron-steering for sleeping times)

Ralf

sdetweil

@lif can you talk about this python after …

MagicMirror upgrades? if so , did you use my upgrade script?

this highlights a problem. some modules need a refresh install when nodejs and MagicMirror change
so the upgrade script does that. but that wipes the node_modules folder for the module. and the dependencies are also not available anymore.

so, if i DO try the npm install it breaks, if i dont try the npm install it might break. fun times.
i will add a check for the authors url and skip the install action

sdetweil

@rkorell i hear yah.

rkorell

@sdetweil said in Bugsounet and MMM-Pir:

some modules need a refresh install

at least in bugsounet’s README.md there is a hint in this direction …

sdetweil

@rkorell yes, but there is nothing I can do… the dependencies no longer exist
he had some integrated update mechanism, I added code to launch that once…
now its dead too…

rkorell

@sdetweil OK.
really unfortunate.
I do not understand these dependencies - so I was hopeful that an update will not destroy module’s ability to work …

So I have to stay with the old mirror version to keep module running?

Regards,
Ralf

lif

@sdetweil said in Bugsounet and MMM-Pir:

@lif can you talk about this python after …

MagicMirror upgrades? if so , did you use my upgrade script?

this highlights a problem. some modules need a refresh install when nodejs and MagicMirror change
so the upgrade script does that. but that wipes the node_modules folder for the module. and the dependencies are also not available anymore.

so, if i DO try the npm install it breaks, if i dont try the npm install it might break. fun times.
i will add a check for the authors url and skip the install action

I was trying to upgrade Nodejs and if failed with lots of errors.

my mm and the whole system had got messy, so I’m using this as an opportunity to clean things up (it didn’t help insofar as a restore from the most recent backup didn’t work.

sdetweil

@rkorell said in Bugsounet and MMM-Pir:

So I have to stay with the old mirror version to keep module running?

i do not know…

I do not understand these dependencies
rather than put all the code in the module, there are libraries of things
that can be called…

so you make those libraries as separate packages and list them in the dependencies section of package.json and npm install goes and gets them

he might have decided that multiple components needs the same functions and packaged as library, to be loaded by all that needed it, code once, ship multiple times…
except that breaks now as the dependencies also are no longer available

as I said in my initial warning post, plan for them all to fail to work