HEIC and MMM-ImagesPhotos

rkorell

@sdetweil HEIC is the Apple iOS version of HEIF (=High Efficiency Image Format) …

rts58

I thought I had tried setting it to 0, but apparently I hadn’t. Now that I have made that change, it is working fine.

The filetype for HEIC is supposed to “image/heic”. I added that to the enabledTypes array in node_helper.js and it now it is also working!

Awesome, as always, thank you Sam!

sdetweil

@rts58 awesome, i’ll submit a pr to update the module

rts58

@sdetweil I am still have trouble with some of the HEIC files.

If the module runs across an unsupported HEIC (or corrupted jpg) file it will just stop and continue showing the last image.

I couldn’t find any log or error for files that won’t open. I’ve compared the files it can and can’t open and don’t see any difference in the file details or exif data. Is there a way to have it just skip the unsupported file?

The module does get locked up, it will not continue with a new image even after the update interval has passed. Thanks for your help.

sdetweil

@rts58 can you look in the developers window console tab

ctrl-shift-i

rts58

@sdetweil yes I’ve been looking at it. If it works I’ll get a message that the image loaded and link, image setting size … , and setting top. If it doesn’t it won’t show anything.

sdetweil

@rts58 ok, i’ll look at error handlers

rts58

@sdetweil if it helps when I dig into the elements it shows:

<img src="/MMM-ImagesPhotos/photo/module_9_MMM-ImagesPhotos/IMG_3259-Copy.HEIC" style="left: 0px; position: relative; opacity: 0;">

So it thinks it is loading the file.

sdetweil

@rts58

in front of

img.onload()

add

img.onerror(){
   this.updateDom()
}

rts58

@sdetweil this is what I did which is creating an uncaught syntax error on the line with the first “{”.

	img.onerror(){
	this.updateDom()
	}
        img.onload = (evt) => {
          // Get the image of the event
          const eventImage = evt.currentTarget;
          Log.log(
            `image loaded=${eventImage.src} size=${eventImage.width}:${eventImage.height}`